You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/12 20:31:25 UTC

[GitHub] vanzin commented on a change in pull request #23380: [WIP][SPARK-26343][KUBERNETES] Try to speed up running local k8s integration tests

vanzin commented on a change in pull request #23380: [WIP][SPARK-26343][KUBERNETES] Try to speed up running local k8s integration tests
URL: https://github.com/apache/spark/pull/23380#discussion_r256134385
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh
 ##########
 @@ -58,15 +58,15 @@ while (( "$#" )); do
   shift
 done
 
-if [[ $SPARK_TGZ == "N/A" ]];
+rm -rf $UNPACKED_SPARK_TGZ
+if [[ $SPARK_TGZ == "N/A" && $IMAGE_TAG == "N/A" ]];
 
 Review comment:
   I think this is too strict. You should be able to build images from the build directory too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org