You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/25 13:39:08 UTC
[GitHub] [hbase] Apache9 opened a new pull request #1206: HBASE-23890 Update
the rsgroup section in our ref guide
Apache9 opened a new pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r384406761
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
Let me confirm. Now the top level balancer will always be RSGroupBasedBalancer, and this option is for the balancer used within a rsgroup. So typically it is not allowed to configured RSGroupBasedBalancer again. But I think a warning here is enough.
And maybe we should also add something in the balancer section to mention that RSGroupBasedBalancer is now the only top level balancer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383916533
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
+enable rs group feature.
+
+The main difference comparing to the old implementation is that, now the
Review comment:
The old implementation is a bit broken, as we can set rsgroup for a namespace, and you can never get this information from the RSGroupInfo. In the new implementation there are two Admin methods for getting the information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383931523
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
+enable rs group feature.
+
+The main difference comparing to the old implementation is that, now the
Review comment:
please include that information in this paragraph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383917827
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
+enable rs group feature.
+
+The main difference comparing to the old implementation is that, now the
+rsgroup for a table is stored in TableDescriptor, instead of in RSGroupInfo,
+so the getTables method of RSGroupInfo has been deprecated. And if you use the
+Admin methods to get the RSGroupInfo, its getTables method will always return
+empty. Of course the behavior for the old RSGroupAdminEndpoint is not changed,
+we will fill the tables field of the RSGroupInfo before returning, to make it
+compatible with old hbase client/shell.
+
+When upgrading, the migration between the RSGroupInfo and TableDescriptor will
Review comment:
Just update the table descriptor, no other effect, you can see the comment in RSGroupInfoManagerImpl.migrate method for more details why this could work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r384476758
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
I would agree in general, but the instructions for using the rsgroup feature expressly called out configuring the balancer. So in this paragraph about migrating we need to call out that they should no longer be doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1206: HBASE-23890 Update
the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#issuecomment-590885908
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-22514 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 36s | HBASE-22514 passed |
| +0 :ok: | refguide | 4m 51s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 1s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 4m 45s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 22m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1206 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 61a3f8d1b8e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh |
| git revision | HBASE-22514 / 77b24fd007 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/artifact/out/patch-site/book.html |
| Max. process+thread count | 96 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383920424
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3347,20 +3346,9 @@ Here is example using a few of the rsgroup commands. To add a group, do as foll
.RegionServer Groups must be Enabled
[NOTE]
====
-If you have not enabled the rsgroup Coprocessor Endpoint in the master and
-you run the any of the rsgroup shell commands, you will see an error message
-like the below:
-
-[source,java]
-----
-ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No registered master coprocessor service found for name RSGroupAdminService
- at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:604)
- at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
- at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:1140)
- at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257)
-----
+If you have not enabled the rsgroup in the master and you call the any of
+rsgroup admin methods, or run the any of the rsgroup shell commands, you may
+see a `DoNotRetryIOException` which tells that 'RSGroup is disabled'
Review comment:
I think the message "RSGroup is disabled" is clear enough? You mean add a "set 'hbase.balancer.rsgroup.enabled' to true if you want to use RSGroup"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r384428798
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
OK, we have this in RSGroupBasedLoadBalancer.initialize
```
// Create the balancer
Class<? extends LoadBalancer> balancerClass;
String balancerClassName = config.get(HBASE_RSGROUP_LOADBALANCER_CLASS);
if (balancerClassName == null) {
balancerClass = config.getClass(HConstants.HBASE_MASTER_LOADBALANCER_CLASS,
LoadBalancerFactory.getDefaultLoadBalancerClass(), LoadBalancer.class);
} else {
try {
balancerClass = Class.forName(balancerClassName).asSubclass(LoadBalancer.class);
} catch (ClassNotFoundException e) {
throw new IOException(e);
}
}
// avoid infinite nesting
if (getClass().isAssignableFrom(balancerClass)) {
balancerClass = LoadBalancerFactory.getDefaultLoadBalancerClass();
}
internalBalancer = ReflectionUtils.newInstance(balancerClass);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383908543
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
+enable rs group feature.
+
+The main difference comparing to the old implementation is that, now the
Review comment:
is there an implementation reason we don't fill in the tables for RSGroupInfo in this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383907721
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
+enable rs group feature.
+
+The main difference comparing to the old implementation is that, now the
+rsgroup for a table is stored in TableDescriptor, instead of in RSGroupInfo,
+so the getTables method of RSGroupInfo has been deprecated. And if you use the
+Admin methods to get the RSGroupInfo, its getTables method will always return
+empty. Of course the behavior for the old RSGroupAdminEndpoint is not changed,
+we will fill the tables field of the RSGroupInfo before returning, to make it
+compatible with old hbase client/shell.
+
+When upgrading, the migration between the RSGroupInfo and TableDescriptor will
Review comment:
what happens wrt group enforcement during the migration? Will regions for grouped tables/namespaces go outside their assigned servers? Will rsgroup administrative commands I run wait to handle moving things in or out of a rsgroup until the migration is done?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383929445
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3347,20 +3346,9 @@ Here is example using a few of the rsgroup commands. To add a group, do as foll
.RegionServer Groups must be Enabled
[NOTE]
====
-If you have not enabled the rsgroup Coprocessor Endpoint in the master and
-you run the any of the rsgroup shell commands, you will see an error message
-like the below:
-
-[source,java]
-----
-ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No registered master coprocessor service found for name RSGroupAdminService
- at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:604)
- at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
- at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:1140)
- at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257)
-----
+If you have not enabled the rsgroup in the master and you call the any of
+rsgroup admin methods, or run the any of the rsgroup shell commands, you may
+see a `DoNotRetryIOException` which tells that 'RSGroup is disabled'
Review comment:
that message would be great! instructions on how to turn it on would be even better, but I'd be happy with a clear statement that the feature is off as the cause.
I see now why I misunderstood. I took "see a X which tells that Y" to mean "you will see X and you should interpret it to mean Y" rather than the intended "you will see X and it will contain details that Y".
suggested edit for this sentence:
> If you have not enabled the rsgroup feature and you call any of the rsgroup admin methods or shell commands the call will fail with a `DoNotRetryIOException` with a detail message that says the rsgroup feature is disabled.
wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383919516
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
No they don't. Actually I think there are two requirements. One is for communicating with pre 3.0.0 hbase client/shell, then you have to set the coprocessor. Another is that you upgrade from pre 3.0.0 to 3.0.0, then we will set the flag to true automatically for you if you have already enabled rs group by the old way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r384454712
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
Checked the ref guide, we haven't mentioned much about the balancer class I think making the top level balancer to be RSGroupBasedLoadBalancer can be considered as an 'implementation detail' so do not mention it in ref guide is fine I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383905794
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
Review comment:
the section on Upgrade Paths needs a call out that points down here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1206: HBASE-23890 Update the
rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#issuecomment-592305420
Any other concerns? @busbey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1206: HBASE-23890 Update
the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#issuecomment-591406672
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-22514 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 37s | HBASE-22514 passed |
| +0 :ok: | refguide | 4m 49s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 1s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 4m 43s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 22m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1206 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux b9cb15d80f0e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh |
| git revision | HBASE-22514 / 1d8e3b7032 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/artifact/out/patch-site/book.html |
| Max. process+thread count | 76 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1206: HBASE-23890 Update
the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#issuecomment-591759524
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 52s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-22514 Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 15s | HBASE-22514 passed |
| +0 :ok: | refguide | 5m 58s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 52s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 5m 32s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 26m 59s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1206 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 45c44fa894b5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh |
| git revision | HBASE-22514 / 1d8e3b7032 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/artifact/out/patch-site/book.html |
| Max. process+thread count | 86 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1206: HBASE-23890 Update
the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#issuecomment-591420505
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-22514 Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 52s | HBASE-22514 passed |
| +0 :ok: | refguide | 7m 58s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 46s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 8m 22s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 33m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1206 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 1b3281eb1438 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh |
| git revision | HBASE-22514 / 1d8e3b7032 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/artifact/out/patch-site/book.html |
| Max. process+thread count | 96 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383904939
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3347,20 +3346,9 @@ Here is example using a few of the rsgroup commands. To add a group, do as foll
.RegionServer Groups must be Enabled
[NOTE]
====
-If you have not enabled the rsgroup Coprocessor Endpoint in the master and
-you run the any of the rsgroup shell commands, you will see an error message
-like the below:
-
-[source,java]
-----
-ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No registered master coprocessor service found for name RSGroupAdminService
- at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:604)
- at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
- at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:1140)
- at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257)
-----
+If you have not enabled the rsgroup in the master and you call the any of
+rsgroup admin methods, or run the any of the rsgroup shell commands, you may
+see a `DoNotRetryIOException` which tells that 'RSGroup is disabled'
Review comment:
Does the `DoNotRetryIOException` make clear that the feature is off? or does it talk about some other thing that we can give an example of here to distinguish from some coincidental failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383932417
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
+enable rs group feature.
+
+The main difference comparing to the old implementation is that, now the
+rsgroup for a table is stored in TableDescriptor, instead of in RSGroupInfo,
+so the getTables method of RSGroupInfo has been deprecated. And if you use the
+Admin methods to get the RSGroupInfo, its getTables method will always return
+empty. Of course the behavior for the old RSGroupAdminEndpoint is not changed,
+we will fill the tables field of the RSGroupInfo before returning, to make it
+compatible with old hbase client/shell.
+
+When upgrading, the migration between the RSGroupInfo and TableDescriptor will
Review comment:
excellent. please add a sentence here that expressly calls out that enforcement will keep working during the migration and running new admin commands is fine.
probably I will get folks asking me how to tell when the migration is complete, so if there's an easy answer to that we should include it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #1206: HBASE-23890 Update the
rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383906368
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
if they're relying on this side effect of configuring the coprocessor, do they also have to be sure to set the custom balancer (as in the old implementation) or does the flag flipping to true take care of that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r384880864
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r384397585
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3347,20 +3346,9 @@ Here is example using a few of the rsgroup commands. To add a group, do as foll
.RegionServer Groups must be Enabled
[NOTE]
====
-If you have not enabled the rsgroup Coprocessor Endpoint in the master and
-you run the any of the rsgroup shell commands, you will see an error message
-like the below:
-
-[source,java]
-----
-ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No registered master coprocessor service found for name RSGroupAdminService
- at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:604)
- at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
- at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:1140)
- at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
- at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257)
-----
+If you have not enabled the rsgroup in the master and you call the any of
+rsgroup admin methods, or run the any of the rsgroup shell commands, you may
+see a `DoNotRetryIOException` which tells that 'RSGroup is disabled'
Review comment:
Thanks. Let me change the words.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r383930944
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
okay good. Presuming there's no harm in still having the balancer customized I think this is fine. If having the balancer customized still is a problem, then we should include a sentence that says "you should remove the custom balancer config"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1206:
HBASE-23890 Update the rsgroup section in our ref guide
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1206: HBASE-23890 Update the rsgroup section in our ref guide
URL: https://github.com/apache/hbase/pull/1206#discussion_r384476758
##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3479,6 +3478,27 @@ To enable ACL, add the following to your hbase-site.xml and restart your Master:
<property>
----
+=== Migrating From Old Implementation
+The coprocessor `org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint` is
+deprected, but for compatible, if you want the pre 3.0.0 hbase client/shell
+to communicate with the new hbase cluster, you still need to add this
+coprocessor to master. And if this coprocessor is specified, the
+`hbase.balancer.rsgroup.enabled` flag will be set to true automatically to
Review comment:
I would agree in general, but the instructions for using the regroup feature expressly called out configuring the balancer. So in this paragraph about migrating we need to call out that they should no longer be doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services