[GitHub] [pulsar] Jason918 commented on a change in pull request #14970: [fix][broker] The offline consumer is not removed from the consumerList

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #14970:
URL: https://github.com/apache/pulsar/pull/14970#discussion_r840406213



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
##########
@@ -153,6 +153,13 @@ public synchronized void addConsumer(Consumer consumer) throws BrokerServiceExce
             throw new ConsumerBusyException("Subscription reached max consumers limit");
         }
 
+        if (consumerList.contains(consumer)) {

Review comment:
       Can you provide the case of duplicated consumer? 
   I wonder if we should replace the old consumer with the new one. The older consumer maybe somewhat expired.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org