You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/04/13 01:09:38 UTC

[jira] Closed: (MPTEST-25) maven.test.failure.ignore ignored by test:match

Message:

   The following issue has been closed.

   Resolver: Brett Porter
       Date: Mon, 12 Apr 2004 7:09 PM

fixed. please be careful with patches - this one caused it never to fail because it isn't checking the failure property.

Also, patches should be attached, not inline, and should be in unified diff format (-u)
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPTEST-25

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPTEST-25
    Summary: maven.test.failure.ignore ignored by test:match
       Type: Improvement

     Status: Closed
   Priority: Minor
 Resolution: FIXED

 Original Estimate: 5 minutes
 Time Spent: Unknown
  Remaining: 5 minutes

    Project: maven-test-plugin

   Assignee: Brett Porter
   Reporter: david swierczek

    Created: Tue, 2 Mar 2004 4:45 PM
    Updated: Mon, 12 Apr 2004 7:09 PM
Environment: v 1.0rc1

Description:
Maven Dev Team,

I've discovered that using the goal "test:match" ignores the setting of
the property "maven.test.failure.ignore" whereas "test:test" abides by
the setting properly.

I was able to fix it in the maven-test-plugin-1.4/plugin.jelly file of
my
environment by using the line as stated in the test:test goal:
	failureProperty="maven.test.failure"
and eliminating the hardcoded "halt on failure stuff".  Here's the diff:

190,191c190
<                  haltonfailure="yes"
<                  haltonerror="yes"
---
>              failureProperty="maven.test.failure"
254,255c253
<                  haltonfailure="yes"
<                  haltonerror="yes"
---
>              failureProperty="maven.test.failure"





---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org