[jira] [Commented] (YARN-7317) Fix overallocation resulted from ceiling in LocalityMulticastAMRMProxyPolicy

["Carlo Curino (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201024#comment-16201024 ] 

Carlo Curino commented on YARN-7317:
------------------------------------

Thanks [~botong] for the improvement. The patch generally looks good, a couple of small issues:
# fix patch to apply to trunk
# line 423 you can mark it as {{@VisibleForTesting}} to signal the method is protected instead of private for testing purposes only
# 444 Non --> No  
# Add a test for {{FederationPolicyUtils}} you can lift it from {{TestWeightedRandomRouterPolicy.testClusterChosenWithRightProbability}}

> Fix overallocation resulted from ceiling in LocalityMulticastAMRMProxyPolicy
> ----------------------------------------------------------------------------
>
>                 Key: YARN-7317
>                 URL: https://issues.apache.org/jira/browse/YARN-7317
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Minor
>         Attachments: YARN-7317.v1.patch
>
>
> When LocalityMulticastAMRMProxyPolicy is splitting up the ANY requests into different subclusters, we are doing Ceil(N * weight), leading to overallocation overall. It is better to do Floor(N * weight) for each subcluster and then assign the residue randomly according to the weights. So that the total number of containers we ask from all subclusters sum up to be N. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org