[jira] [Commented] (CALCITE-1461) Hard coded class name in JaninoRelMetadataProvider breaks shading

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600048#comment-15600048 ] 

Julian Hyde commented on CALCITE-1461:
--------------------------------------

Yes, please make a PR. I expect other people want to shade Calcite too (a sign of our increasing popularity, I guess).

> Hard coded class name in JaninoRelMetadataProvider breaks shading
> -----------------------------------------------------------------
>
>                 Key: CALCITE-1461
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1461
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Jark Wu
>            Assignee: Julian Hyde
>
> In {{JaninoRelMetadataProvider.load3}}, the generated class string contains some hard coded Calcite's classes, such as {{org.apache.calcite.rel.metadata.MetadataDef}}. After shading Calcite, the MetadataDef can not be found in the shaded classes. And a compile error will be thrown.
> So it's better to use {{MetadataDef.class.getName()}} to replace the hard code string.
> I'm appreciate to make a PR if you want. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)