You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/02 10:36:13 UTC

[GitHub] [arrow-datafusion] jorgecarleitao commented on a change in pull request #476: add random and now function

jorgecarleitao commented on a change in pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476#discussion_r643833941



##########
File path: python/src/functions.rs
##########
@@ -149,13 +157,27 @@ fn md5(value: expression::Expression) -> expression::Expression {
     }
 }
 
+#[pyfunction]
+fn now(value: expression::Expression) -> expression::Expression {
+    expression::Expression {
+        expr: logical_plan::now(value.expr),

Review comment:
       Do you know why the logical `now` has one argument? I though that the physical one had the `NullArray`, but that in the logical plane, the function would be zero-argument?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org