You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/22 07:57:32 UTC

[GitHub] [iotdb] mychaow commented on a change in pull request #2558: Fix delete dead lock

mychaow commented on a change in pull request #2558:
URL: https://github.com/apache/iotdb/pull/2558#discussion_r562447081



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1828,14 +1828,14 @@ private void upgradeTsFileResourceCallBack(TsFileResource tsFileResource) {
     upgradeFileCount.getAndAdd(-1);
     // load all upgraded resources in this sg to tsFileManagement
     if (upgradeFileCount.get() == 0) {
-      insertLock.writeLock().lock();  
       tsFileManagement.writeLock();
+      insertLock.writeLock().lock();  

Review comment:
       change it to writeLock(）？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org