You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2010/11/21 21:35:06 UTC

svn commit: r1037552 - /subversion/branches/performance/subversion/libsvn_fs_fs/fs_fs.c

Author: stefan2
Date: Sun Nov 21 20:35:06 2010
New Revision: 1037552

URL: http://svn.apache.org/viewvc?rev=1037552&view=rev
Log:
Fix error leak and potentially indefinite loop.

* subversion/libsvn_fs_fs/fs_fs.c
  (open_pack_or_rev_file): fix error leak

Modified:
    subversion/branches/performance/subversion/libsvn_fs_fs/fs_fs.c

Modified: subversion/branches/performance/subversion/libsvn_fs_fs/fs_fs.c
URL: http://svn.apache.org/viewvc/subversion/branches/performance/subversion/libsvn_fs_fs/fs_fs.c?rev=1037552&r1=1037551&r2=1037552&view=diff
==============================================================================
--- subversion/branches/performance/subversion/libsvn_fs_fs/fs_fs.c (original)
+++ subversion/branches/performance/subversion/libsvn_fs_fs/fs_fs.c Sun Nov 21 20:35:06 2010
@@ -1984,10 +1984,14 @@ open_pack_or_rev_file(svn_file_handle_ca
 
           retry = TRUE;
         }
+      else
+        {
+          return svn_error_return(err);
+        }
     }
-  while (err && retry);
+  while (err);
 
-  return svn_error_return(err);
+  return SVN_NO_ERROR;
 }
 
 /* Given REV in FS, set *REV_OFFSET to REV's offset in the packed file.