You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "michaelbeaumont (via GitHub)" <gi...@apache.org> on 2026/10/09 09:15:12 UTC
[PR] fix: Check length and codepoints when resolving String to Fixed [avro-rs]
michaelbeaumont opened a new pull request, #700:
URL: https://github.com/apache/avro-rs/pull/700
Resolves the same issue as #542 which seems to have stalled, but also the string to fixed conversion itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Check length and codepoints when resolving String to Fixed [avro-rs]
Posted by "michaelbeaumont (via GitHub)" <gi...@apache.org>.
michaelbeaumont commented on code in PR #700:
URL: https://github.com/apache/avro-rs/pull/700#discussion_r4252115363
##########
avro/src/types.rs:
##########
@@ -3664,6 +3685,80 @@ mod tests {
Ok(())
}
+ #[test]
+ fn resolve_fixed_from_string_checks_size() -> TestResult {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Check length and codepoints when resolving String to Fixed [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 commented on code in PR #700:
URL: https://github.com/apache/avro-rs/pull/700#discussion_r4251939190
##########
avro/src/types.rs:
##########
@@ -3664,6 +3685,80 @@ mod tests {
Ok(())
}
+ #[test]
+ fn resolve_fixed_from_string_checks_size() -> TestResult {
Review Comment:
Please add `avro_rs_700_` to the beginning of all test names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Check length and codepoints when resolving String to Fixed [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 merged PR #700:
URL: https://github.com/apache/avro-rs/pull/700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org