[GitHub] [flink] pnowojski commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555020073



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
 import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
 import org.apache.flink.streaming.api.graph.StreamConfig;
 import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;

Review comment:
       I don't have opinion about this. Could be moved together.
   
   However one thing, I'm not sure if `org.apache.flink.streaming.runtime.tasks.checkpointing` is the best fit. Those classes have very little in common with `task` package and it's content `StreamTask`, `OperatorChain` etc. Why not to move all of it to `org.apache.flink.streaming.runtime.io.checkpointing`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org