You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/19 07:49:50 UTC
[GitHub] [incubator-seatunnel] FWLamb opened a new pull request, #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
FWLamb opened a new pull request, #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Clickhouse Sink Support write Geo type https://github.com/apache/incubator-seatunnel/issues/3101
Clickhouse Source also Support Geo type.
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1286716029
Like this https://github.com/apache/incubator-seatunnel/pull/3047/files#diff-74e1e7a8b81b6f0f364b14de8bf7f0957bcea7d13f1ce23c61be650844fc2ecd , you should turn on clickhouse e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FWLamb commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
FWLamb commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1298120979
> Please add the improve to Clickhouse Connector doc and add the `changed log` reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version
all right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1298135330
> #3067 #3047 @EricJoy2048 Do the above two PRs also need to be added?
Yes, add it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FWLamb commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
FWLamb commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1286713622
Point and Ring data types passed the e2e test. Polygon and MultiPolygon cannot be used temporarily because of a bug in clickhouse jdbc. Please track https://github.com/ClickHouse/clickhouse-jdbc/issues/1112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FWLamb commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
FWLamb commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1298145334
> > #3067 #3047 @EricJoy2048 Do the above two PRs also need to be added?
>
> Yes, add it together.
all right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1286680699
Please use e2e to test there type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FWLamb commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
FWLamb commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1296943991
@Hisoka-X PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FWLamb commented on pull request #3141: [Improve][Clickhouse-V2] Clickhouse Support Geo type
Posted by GitBox <gi...@apache.org>.
FWLamb commented on PR #3141:
URL: https://github.com/apache/incubator-seatunnel/pull/3141#issuecomment-1298127885
https://github.com/apache/incubator-seatunnel/pull/3067
https://github.com/apache/incubator-seatunnel/pull/3047
@EricJoy2048 Do the above two PRs also need to be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org