You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by mj...@apache.org on 2019/08/19 07:11:25 UTC
[guacamole-client] branch master updated (df8b8ab -> 339c920)
This is an automated email from the ASF dual-hosted git repository.
mjumper pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/guacamole-client.git.
from df8b8ab GUACAMOLE-769: Merge fix for regression in appearance of RADIUS challenge/response interface.
add a710558 GUACAMOLE-684: Insufficient credentials should take precedence over other credentials errors.
new 339c920 GUACAMOLE-684: Merge changes giving tentative acceptance of credentials priority over complete refusal.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/guacamole/rest/auth/AuthenticationService.java | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
[guacamole-client] 01/01: GUACAMOLE-684: Merge changes giving
tentative acceptance of credentials priority over complete refusal.
Posted by mj...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mjumper pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/guacamole-client.git
commit 339c920a89ba6d2363bd442d77490b00237ce650
Merge: df8b8ab a710558
Author: Mike Jumper <mj...@apache.org>
AuthorDate: Mon Aug 19 00:11:19 2019 -0700
GUACAMOLE-684: Merge changes giving tentative acceptance of credentials priority over complete refusal.
As described in the discussion surrounding the original pull request:
* An extension throws `GuacamoleInsufficientCredentialsException`
specifically to indicate tentative acceptance of the credentials
passed thus far.
* Just as such an extension that fully accepts credentials takes
priority over an extension that refuses to accept the same, it makes
sense to allow an extension that *tentatively* accepts those credentials
to also take priority.
With the above perspective, authentication result priorities are as
follows, with ties broken by the inherent order of the auth providers:
1. Acceptance (returning an `AuthenticedUser` instance).
2. Tentative acceptance (throwing
`GuacamoleInvalidCredentialsException`).
3. Complete refusal (any other subclass of
`GuacamoleCredentialsException`).
4. Neither refusal nor acceptance (returning `null`).
See: https://github.com/apache/guacamole-client/pull/352
.../org/apache/guacamole/rest/auth/AuthenticationService.java | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)