[jira] [Commented] (YARN-2118) Type mismatch in contains() check of TimelineWebServices#injectOwnerInfo()

["Zhijie Shen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020034#comment-14020034 ] 

Zhijie Shen commented on YARN-2118:
-----------------------------------

The patch looks good to me. Just one nit: given the test cases may run out of order with Java 7. Would you please change the id and type not to conflict with other test cases, because the store is a static thing
{code}
+    entity.setEntityId("test id 1");
+    entity.setEntityType("test type 1");
{code}

> Type mismatch in contains() check of TimelineWebServices#injectOwnerInfo()
> --------------------------------------------------------------------------
>
>                 Key: YARN-2118
>                 URL: https://issues.apache.org/jira/browse/YARN-2118
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: yarn-2118-v1.txt, yarn-2118-v2.txt
>
>
> {code}
>     if (timelineEntity.getPrimaryFilters() != null &&
>         timelineEntity.getPrimaryFilters().containsKey(
>             TimelineStore.SystemFilter.ENTITY_OWNER)) {
>       throw new YarnException(
> {code}
> getPrimaryFilters() returns a Map keyed by String.
> However, TimelineStore.SystemFilter.ENTITY_OWNER is an enum.
> Their types don't match.



--
This message was sent by Atlassian JIRA
(v6.2#6252)