You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/20 18:05:10 UTC
[GitHub] [zeppelin] Jiabao-Sun opened a new pull request #4099: Add configuration of flink.udf.packages and flink.udf.packages.packages
Jiabao-Sun opened a new pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099
### What is this PR for?
Add flink.udf.packages configuration to support udf jars in maven repository.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-5332]
### How should this be tested?
* Strongly recommended: add automated unit tests for any new or changed behavior
* Set flink.udf.packages and flink.udf.packages.packages configuration and verify the udf functions is loaded correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] cuspymd commented on a change in pull request #4099: [ZEPPELIN-5332] Add configuration of flink.udf.packages and flink.udf.packages.packages
Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r617569641
##########
File path: docs/interpreter/flink.md
##########
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are not listed in the tabl
<td></td>
<td>Packages (comma separated) that would be searched for the udf defined in `flink.udf.jars`.</td>
</tr>
+ <tr>
+ <td>flink.udf.packages</td>
+ <td></td>
+ <td>Flink udf packages (comma separated), zeppelin will register udf in this jar automatically for user. These udf packages could be found in the maven central or private repository. The udf name is the class name. e.g. org.apache.flink:flink-udfs-demo0:1.10.0,org.apache.flink:flink-udfs-demo1:1.10.0</td>
+ </tr>
+ <tr>
+ <td>flink.udf.packages.packages</td>
Review comment:
There are several properties with similar names, so it seems difficult to understand the difference between them without checking how they are used in the actual code from the user's point of view.
- flink.udf.jars
- flink.udf.jars.packages
- flink.udf.packages
- flink.udf.packages.packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4099: [ZEPPELIN-5332] Add configuration of flink.udf.packages and flink.udf.packages.packages
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r618073216
##########
File path: docs/interpreter/flink.md
##########
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are not listed in the tabl
<td></td>
<td>Packages (comma separated) that would be searched for the udf defined in `flink.udf.jars`.</td>
</tr>
+ <tr>
+ <td>flink.udf.packages</td>
+ <td></td>
+ <td>Flink udf packages (comma separated), zeppelin will register udf in this jar automatically for user. These udf packages could be found in the maven central or private repository. The udf name is the class name. e.g. org.apache.flink:flink-udfs-demo0:1.10.0,org.apache.flink:flink-udfs-demo1:1.10.0</td>
+ </tr>
+ <tr>
+ <td>flink.udf.packages.packages</td>
Review comment:
Yes，the naming is a little confusing. I would suggest to use :
* flink.udf.jars
* flink.udf.packages
And them use `flink.udf.search.packages` to replace `flink.udf.jars.packages` for which packages to search for udf classes. But this may introduce incompatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Jiabao-Sun closed pull request #4099: [ZEPPELIN-5332] Add configuration of flink.udf.packages and flink.udf.packages.packages
Posted by GitBox <gi...@apache.org>.
Jiabao-Sun closed pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Jiabao-Sun commented on a change in pull request #4099: [ZEPPELIN-5332] Add configuration of flink.udf.packages and flink.udf.packages.packages
Posted by GitBox <gi...@apache.org>.
Jiabao-Sun commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r617670254
##########
File path: docs/interpreter/flink.md
##########
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are not listed in the tabl
<td></td>
<td>Packages (comma separated) that would be searched for the udf defined in `flink.udf.jars`.</td>
</tr>
+ <tr>
+ <td>flink.udf.packages</td>
+ <td></td>
+ <td>Flink udf packages (comma separated), zeppelin will register udf in this jar automatically for user. These udf packages could be found in the maven central or private repository. The udf name is the class name. e.g. org.apache.flink:flink-udfs-demo0:1.10.0,org.apache.flink:flink-udfs-demo1:1.10.0</td>
+ </tr>
+ <tr>
+ <td>flink.udf.packages.packages</td>
Review comment:
This is true, but the basis for naming is to refer to fink.execution.packages.
It may cause misunderstandings and compatibility issues with the old code, if we change this naming style.
If there is a more suitable name, I hope to get your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Jiabao-Sun commented on a change in pull request #4099: [ZEPPELIN-5332] Add configuration of flink.udf.packages and flink.udf.packages.packages
Posted by GitBox <gi...@apache.org>.
Jiabao-Sun commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r618104488
##########
File path: docs/interpreter/flink.md
##########
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are not listed in the tabl
<td></td>
<td>Packages (comma separated) that would be searched for the udf defined in `flink.udf.jars`.</td>
</tr>
+ <tr>
+ <td>flink.udf.packages</td>
+ <td></td>
+ <td>Flink udf packages (comma separated), zeppelin will register udf in this jar automatically for user. These udf packages could be found in the maven central or private repository. The udf name is the class name. e.g. org.apache.flink:flink-udfs-demo0:1.10.0,org.apache.flink:flink-udfs-demo1:1.10.0</td>
+ </tr>
+ <tr>
+ <td>flink.udf.packages.packages</td>
Review comment:
Thanks @cuspymd and @zjffdu.
I renamed flink.udf.jars.packages to flink.udf.search.packages in a new commit.
Please help to review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] cuspymd commented on a change in pull request #4099: [ZEPPELIN-5332] Add configuration of flink.udf.packages and flink.udf.packages.packages
Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r618062546
##########
File path: docs/interpreter/flink.md
##########
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are not listed in the tabl
<td></td>
<td>Packages (comma separated) that would be searched for the udf defined in `flink.udf.jars`.</td>
</tr>
+ <tr>
+ <td>flink.udf.packages</td>
+ <td></td>
+ <td>Flink udf packages (comma separated), zeppelin will register udf in this jar automatically for user. These udf packages could be found in the maven central or private repository. The udf name is the class name. e.g. org.apache.flink:flink-udfs-demo0:1.10.0,org.apache.flink:flink-udfs-demo1:1.10.0</td>
+ </tr>
+ <tr>
+ <td>flink.udf.packages.packages</td>
Review comment:
Maybe I feel difficult because I don't have domain knowledge. For those familiar with flink, if these property names are familiar, it doesn't matter. @zjffdu What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Jiabao-Sun commented on a change in pull request #4099: [ZEPPELIN-5332] Add configuration of flink.udf.packages and flink.udf.packages.packages
Posted by GitBox <gi...@apache.org>.
Jiabao-Sun commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r617670254
##########
File path: docs/interpreter/flink.md
##########
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are not listed in the tabl
<td></td>
<td>Packages (comma separated) that would be searched for the udf defined in `flink.udf.jars`.</td>
</tr>
+ <tr>
+ <td>flink.udf.packages</td>
+ <td></td>
+ <td>Flink udf packages (comma separated), zeppelin will register udf in this jar automatically for user. These udf packages could be found in the maven central or private repository. The udf name is the class name. e.g. org.apache.flink:flink-udfs-demo0:1.10.0,org.apache.flink:flink-udfs-demo1:1.10.0</td>
+ </tr>
+ <tr>
+ <td>flink.udf.packages.packages</td>
Review comment:
This is true, but the basis for naming is to refer to fink.udf.packages.
It may cause misunderstandings and compatibility issues with the old code, if we change this naming style.
If there is a more suitable name, I hope to get your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org