[GitHub] [commons-exec] garydgregory commented on a diff in pull request #61: [Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException

[GitBox <gi...@apache.org>]

garydgregory commented on code in PR #61:
URL: https://github.com/apache/commons-exec/pull/61#discussion_r978954072


##########
src/main/java/org/apache/commons/exec/CommandLine.java:
##########
@@ -398,6 +398,7 @@ private static String[] translateCommandline(final String toProcess) {
      *
      * @param dirtyExecutable the executable
      * @return the platform-specific executable string
+     * @throws IllegalArgumentException If dirtyExecutable is null or empty

Review Comment:
   Hello @ArdenL-Liu 
   Thank you for your PR.
   You might as well update the other Javadoc instances in this class where IllegalArgumentException is thrown but not documented, especially since we seem to document some but not all cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org