You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Carlin Rogers (JIRA)" <de...@beehive.apache.org> on 2006/03/31 19:47:01 UTC
[jira] Created: (BEEHIVE-1090) NetUI page flow compiler's
WebappPathType.checkRelativePath() needs to handle paths to JPF that begin
with "./"
NetUI page flow compiler's WebappPathType.checkRelativePath() needs to handle paths to JPF that begin with "./"
---------------------------------------------------------------------------------------------------------------
Key: BEEHIVE-1090
URL: http://issues.apache.org/jira/browse/BEEHIVE-1090
Project: Beehive
Type: Bug
Components: NetUI
Versions: 1.0.1
Reporter: Carlin Rogers
Assigned to: Carlin Rogers
Priority: Minor
Fix For: v.next
Add an action such as the following to a page flow controller:
@Jpf.Action(forwards = {
@Jpf.Forward(name = "success",
path = "./subdir/Controller.jpf")
})
protected Forward AddAction() { ... }
As the jpf compiler does its thing, it translates external pageflow paths into type names and then requests those types. Here it is incorrectly translating "./subdir/Controller.jpf" to a type name "..subdir.Controller"
which may cause an APT implementation to barf when we try to get a TypeDeclaration from this name. With the Sun APT, we get a null type without an error, but then this causes us to write a warning that we cannot find the page flow for the given path.
The problem is in org.apache.beehive.netui.compiler.grammar.WebappPathType.checkRelativePath(). It does some stuff to look for "../" at the beginning of a path but does not handle "./".
I'll add a zip file for the repro. The fix is coming shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-1090) NetUI page flow compiler's
WebappPathType.checkRelativePath() needs to handle paths to JPF that begin
with "./"
Posted by "Carlin Rogers (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-1090?page=all ]
Carlin Rogers resolved BEEHIVE-1090:
------------------------------------
Resolution: Fixed
Assign To: Julie Zhuo (was: Carlin Rogers)
This is fixed with revision 390477. It includes a new compiler test.
http://svn.apache.org/viewcvs?rev=390477&view=rev
> NetUI page flow compiler's WebappPathType.checkRelativePath() needs to handle paths to JPF that begin with "./"
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-1090
> URL: http://issues.apache.org/jira/browse/BEEHIVE-1090
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: 1.0.1
> Reporter: Carlin Rogers
> Assignee: Julie Zhuo
> Priority: Minor
> Fix For: v.next
> Attachments: j1090-repro.zip
>
> Add an action such as the following to a page flow controller:
> @Jpf.Action(forwards = {
> @Jpf.Forward(name = "success",
> path = "./subdir/Controller.jpf")
> })
> protected Forward AddAction() { ... }
> As the jpf compiler does its thing, it translates external pageflow paths into type names and then requests those types. Here it is incorrectly translating "./subdir/Controller.jpf" to a type name "..subdir.Controller"
> which may cause an APT implementation to barf when we try to get a TypeDeclaration from this name. With the Sun APT, we get a null type without an error, but then this causes us to write a warning that we cannot find the page flow for the given path.
> The problem is in org.apache.beehive.netui.compiler.grammar.WebappPathType.checkRelativePath(). It does some stuff to look for "../" at the beginning of a path but does not handle "./".
> I'll add a zip file for the repro. The fix is coming shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-1090) NetUI page flow compiler's
WebappPathType.checkRelativePath() needs to handle paths to JPF that begin
with "./"
Posted by "Carlin Rogers (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-1090?page=all ]
Carlin Rogers updated BEEHIVE-1090:
-----------------------------------
Attachment: j1090-repro.zip
Zip file with test to repro warnings that the JPF in the forward path could not be found...
> NetUI page flow compiler's WebappPathType.checkRelativePath() needs to handle paths to JPF that begin with "./"
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-1090
> URL: http://issues.apache.org/jira/browse/BEEHIVE-1090
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: 1.0.1
> Reporter: Carlin Rogers
> Assignee: Carlin Rogers
> Priority: Minor
> Fix For: v.next
> Attachments: j1090-repro.zip
>
> Add an action such as the following to a page flow controller:
> @Jpf.Action(forwards = {
> @Jpf.Forward(name = "success",
> path = "./subdir/Controller.jpf")
> })
> protected Forward AddAction() { ... }
> As the jpf compiler does its thing, it translates external pageflow paths into type names and then requests those types. Here it is incorrectly translating "./subdir/Controller.jpf" to a type name "..subdir.Controller"
> which may cause an APT implementation to barf when we try to get a TypeDeclaration from this name. With the Sun APT, we get a null type without an error, but then this causes us to write a warning that we cannot find the page flow for the given path.
> The problem is in org.apache.beehive.netui.compiler.grammar.WebappPathType.checkRelativePath(). It does some stuff to look for "../" at the beginning of a path but does not handle "./".
> I'll add a zip file for the repro. The fix is coming shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira