You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Matthias Wessendorf <ma...@apache.org> on 2006/09/27 13:37:30 UTC
ADFFACES-203
Any objects regarding [1]
[1] https://issues.apache.org/jira/browse/ADFFACES-203
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: Re: ADFFACES-203
Posted by Simon Lessard <si...@gmail.com>.
Nvm that previous message, renderStyleClass has a different signature than
the array one. So renderStyleClass*es* should not becalled too often with
asingle class indeed.
~ Simon
On 9/28/06, Simon Lessard <si...@gmail.com> wrote:
>
> We'll have to check if overloading works with varargs before applying that
> change then.
>
> On 9/27/06, Adam Winer <awiner@gmail.com > wrote:
> >
> > Simon,
> >
> > We should keep an ordinary String renderStyleClass() API,
> > because the one-element case is so common. I don't
> > want to force everything through the varargs bottleneck,
> > which will allocate *a lot* of unnecessary one-element arrays.
> >
> > -- Adam
> >
> >
> > On 9/27/06, Matthias Wessendorf < matzew@apache.org> wrote:
> > > yeah, forgot that discussion from you ;)
> > >
> > > thanks!
> > >
> > > On 9/27/06, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > Yes and no,
> > > >
> > > > If we add varargs, it will always be an array, even when you send a
> > single
> > > > String, so one element String will actually be decently common.
> > > >
> > > > On 9/27/06, Adam Winer <aw...@gmail.com> wrote:
> > > > >
> > > > > Weeelll... I wonder whether this is actually an optimization,
> > > > > because who would ever call renderStyleClasses() with
> > > > > a one-element array? If no one ever does that, then this
> > > > > in fact makes the code a bit slower.
> > > > >
> > > > > -- Adam
> > > > >
> > > > >
> > > > > On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > Any objects regarding [1]
> > > > > >
> > > > > > [1] https://issues.apache.org/jira/browse/ADFFACES-203
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > > http://tinyurl.com/fmywh
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
>
>
Re: Re: ADFFACES-203
Posted by Simon Lessard <si...@gmail.com>.
We'll have to check if overloading works with varargs before applying that
change then.
On 9/27/06, Adam Winer <aw...@gmail.com> wrote:
>
> Simon,
>
> We should keep an ordinary String renderStyleClass() API,
> because the one-element case is so common. I don't
> want to force everything through the varargs bottleneck,
> which will allocate *a lot* of unnecessary one-element arrays.
>
> -- Adam
>
>
> On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > yeah, forgot that discussion from you ;)
> >
> > thanks!
> >
> > On 9/27/06, Simon Lessard <si...@gmail.com> wrote:
> > > Yes and no,
> > >
> > > If we add varargs, it will always be an array, even when you send a
> single
> > > String, so one element String will actually be decently common.
> > >
> > > On 9/27/06, Adam Winer <aw...@gmail.com> wrote:
> > > >
> > > > Weeelll... I wonder whether this is actually an optimization,
> > > > because who would ever call renderStyleClasses() with
> > > > a one-element array? If no one ever does that, then this
> > > > in fact makes the code a bit slower.
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > Any objects regarding [1]
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/ADFFACES-203
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > > http://tinyurl.com/fmywh
> > > > >
> > > > > further stuff:
> > > > > blog: http://jroller.com/page/mwessendorf
> > > > > mail: mwessendorf-at-gmail-dot-com
> > > > >
> > > >
> > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
Re: Re: ADFFACES-203
Posted by Adam Winer <aw...@gmail.com>.
Simon,
We should keep an ordinary String renderStyleClass() API,
because the one-element case is so common. I don't
want to force everything through the varargs bottleneck,
which will allocate *a lot* of unnecessary one-element arrays.
-- Adam
On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> yeah, forgot that discussion from you ;)
>
> thanks!
>
> On 9/27/06, Simon Lessard <si...@gmail.com> wrote:
> > Yes and no,
> >
> > If we add varargs, it will always be an array, even when you send a single
> > String, so one element String will actually be decently common.
> >
> > On 9/27/06, Adam Winer <aw...@gmail.com> wrote:
> > >
> > > Weeelll... I wonder whether this is actually an optimization,
> > > because who would ever call renderStyleClasses() with
> > > a one-element array? If no one ever does that, then this
> > > in fact makes the code a bit slower.
> > >
> > > -- Adam
> > >
> > >
> > > On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > Any objects regarding [1]
> > > >
> > > > [1] https://issues.apache.org/jira/browse/ADFFACES-203
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
Re: ADFFACES-203
Posted by Matthias Wessendorf <ma...@apache.org>.
yeah, forgot that discussion from you ;)
thanks!
On 9/27/06, Simon Lessard <si...@gmail.com> wrote:
> Yes and no,
>
> If we add varargs, it will always be an array, even when you send a single
> String, so one element String will actually be decently common.
>
> On 9/27/06, Adam Winer <aw...@gmail.com> wrote:
> >
> > Weeelll... I wonder whether this is actually an optimization,
> > because who would ever call renderStyleClasses() with
> > a one-element array? If no one ever does that, then this
> > in fact makes the code a bit slower.
> >
> > -- Adam
> >
> >
> > On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > Any objects regarding [1]
> > >
> > > [1] https://issues.apache.org/jira/browse/ADFFACES-203
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
>
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: ADFFACES-203
Posted by Simon Lessard <si...@gmail.com>.
Yes and no,
If we add varargs, it will always be an array, even when you send a single
String, so one element String will actually be decently common.
On 9/27/06, Adam Winer <aw...@gmail.com> wrote:
>
> Weeelll... I wonder whether this is actually an optimization,
> because who would ever call renderStyleClasses() with
> a one-element array? If no one ever does that, then this
> in fact makes the code a bit slower.
>
> -- Adam
>
>
> On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > Any objects regarding [1]
> >
> > [1] https://issues.apache.org/jira/browse/ADFFACES-203
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
Re: ADFFACES-203
Posted by Adam Winer <aw...@gmail.com>.
Weeelll... I wonder whether this is actually an optimization,
because who would ever call renderStyleClasses() with
a one-element array? If no one ever does that, then this
in fact makes the code a bit slower.
-- Adam
On 9/27/06, Matthias Wessendorf <ma...@apache.org> wrote:
> Any objects regarding [1]
>
> [1] https://issues.apache.org/jira/browse/ADFFACES-203
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>