You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/03 02:13:15 UTC
[GitHub] [spark] beliefer opened a new pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
beliefer opened a new pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439
### What changes were proposed in this pull request?
When I running the `window_part2.sql` tests find it lack insert sql. Therefore, the output is empty.
I checked the postgresql and reference https://github.com/postgres/postgres/blob/master/src/test/regress/sql/window.sql
Although `window_part1.sql` and `window_part3.sql` exists the insert sql, I think should also add it into `window_part2.sql`.
Note: window_part4.sql not use the table `empsalary`.
### Why are the changes needed?
Supplementary test data.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
New test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287740
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581254453
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117756/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582756152
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581210324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22518/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582543334
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375431594
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part2.sql.out
##########
@@ -72,17 +59,6 @@ struct<sum(unique1) OVER (PARTITION BY four ORDER BY unique1 ASC NULLS FIRST RAN
8 6 2
--- !query
-select last(salary) over(order by salary range between 1000 preceding and 1000 following),
-lag(salary) over(order by salary range between 1000 preceding and 1000 following),
-salary from empsalary
--- !query schema
-struct<>
--- !query output
-org.apache.spark.sql.AnalysisException
-Window Frame specifiedwindowframe(RangeFrame, -1000, 1000) must match the required frame specifiedwindowframe(RowFrame, -1, -1);
Review comment:
We also have many test cases to check exception error messages to prevent any unintentional behavior changes (both good or bed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582687250
@HyukjinKwon .
The same author (@beliefer ) are actively working this area.
- NTH: https://github.com/apache/spark/pull/27440
- FIRST_VALUE/LAST_VALUE: he wrote on the JIRA, he will start after NTH.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582756401
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287945
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117883/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582543342
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117935/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582690603
> Thanks @dongjoon-hyun. @beliefer, do you plan to support these soon? If that's the case let's bring `CREATE` and `INSERT` back here.
I think some feature will be supported, the other ones will not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375009659
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
+ ('develop', 10, 5200, date '2007-08-01'),
+ ('sales', 1, 5000, date '2006-10-01'),
+ ('personnel', 5, 3500, date '2007-12-10'),
+ ('sales', 4, 4800, date '2007-08-08'),
+ ('personnel', 2, 3900, date '2006-12-23'),
+ ('develop', 7, 4200, date '2008-01-01'),
+ ('develop', 9, 4500, date '2008-01-01'),
+ ('sales', 3, 4800, date '2007-08-01'),
+ ('develop', 8, 6000, date '2006-10-01'),
+ ('develop', 11, 5200, date '2007-08-15');
Review comment:
Once https://github.com/apache/spark/pull/27439/files#r375009397 is addressed, there's no point of creating this table anymore because it's used nowhere. I think you can comment out both CREATE and INSERT, with commenting it's currently not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582410614
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22698/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582220163
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22638/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375044935
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -8,12 +8,24 @@
--CONFIG_DIM1 spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=CODEGEN_ONLY
--CONFIG_DIM1 spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=NO_CODEGEN
-CREATE TABLE empsalary (
- depname string,
- empno integer,
- salary int,
- enroll_date date
-) USING parquet;
+-- CREATE TABLE empsalary (
+-- depname string,
+-- empno integer,
+-- salary int,
+-- enroll_date date
+--- ) USING parquet;
Review comment:
Uh， I'm not notice it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375612978
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -99,6 +111,7 @@ FROM tenk1 WHERE unique1 < 10;
-- nth_value(salary, 1) over(order by salary range between 1000 preceding and 1000 following),
-- salary from empsalary;
+-- [SPARK-30734] AnalysisException that window RangeFrame not match RowFrame
select last(salary) over(order by salary range between 1000 preceding and 1000 following),
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287744
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117908/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582398666
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582708611
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582281756
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582410614
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22698/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582229389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22645/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582700616
LGTM otherwise. Sorry for a bit of back and forth @beliefer but mind updating PR description back as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582224884
BTW, @beliefer, don't forget to update PR description and title accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582707838
> LGTM otherwise. Sorry for a bit of back and forth @beliefer but mind updating PR description back as well?
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582407811
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582229128
**[Test build #117883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117883/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582297063
**[Test build #117921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117921/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582773145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117963/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582281507
**[Test build #117876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117876/testReport)** for PR 27439 at commit [`50d713e`](https://github.com/apache/spark/commit/50d713e9293aed183f496a29ad300049fed4a84d).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582708615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22727/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582699155
**[Test build #117959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117959/testReport)** for PR 27439 at commit [`4e27e98`](https://github.com/apache/spark/commit/4e27e984e766e65b56243c9e036d7b4ad2b6a798).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582220163
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22638/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582229389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22645/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582295828
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582685622
> If we start to support more queries in this file, we need to bring them back.
> Let's not decide what is not required at this stage.
@dongjoon-hyun, the flip side also works. For the time we don't support, we can save one INSERT and CREATE operation in test base until that point. I don't think keeping unused data or codes in test cases is right. We should bring it back only when it's used. (e.g., we should remove unused codes rather then keeping it just in case it's used in the future).
Just to be clear, is this inconsistent with other ported tests in PostgreSQL? If that's the case, let's just revert back to revive `CREATE` and `INSERT` - I don't mind just keeping it simple and consistent.; otherwise, I think we can just go ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581254444
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287646
**[Test build #117908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117908/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287945
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117883/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582685622
> If we start to support more queries in this file, we need to bring them back.
> Let's not decide what is not required at this stage.
@dongjoon-hyun, the flip side also works. For the time we don't support, we can save one INSERT and CREATE operation in test base until that point. I don't think keeping unused data or codes in test cases is right. We should bring it back only when it's used. (e.g., we should remove unused codes rather then keeping it just in case it's used in the future).
Just to be clear, is this inconsistent with other ported tests in PostgreSQL? If that's the case, let's revive; otherwise, I think we can just go ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582282101
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582708611
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375606531
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -99,6 +111,7 @@ FROM tenk1 WHERE unique1 < 10;
-- nth_value(salary, 1) over(order by salary range between 1000 preceding and 1000 following),
-- salary from empsalary;
+-- [SPARK-30734] AnalysisException that window RangeFrame not match RowFrame
select last(salary) over(order by salary range between 1000 preceding and 1000 following),
Review comment:
Sorry if I wasn't clear. I think this one still should comment this case out since we don't support. This is a positive case in PostgreSQL, and looks odds to convert this one alone to a negative test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581210320
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582697509
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582697522
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22723/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582398666
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582282110
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117876/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582221476
**[Test build #117876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117876/testReport)** for PR 27439 at commit [`50d713e`](https://github.com/apache/spark/commit/50d713e9293aed183f496a29ad300049fed4a84d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375596757
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part2.sql.out
##########
@@ -72,17 +59,6 @@ struct<sum(unique1) OVER (PARTITION BY four ORDER BY unique1 ASC NULLS FIRST RAN
8 6 2
--- !query
-select last(salary) over(order by salary range between 1000 preceding and 1000 following),
-lag(salary) over(order by salary range between 1000 preceding and 1000 following),
-salary from empsalary
--- !query schema
-struct<>
--- !query output
-org.apache.spark.sql.AnalysisException
-Window Frame specifiedwindowframe(RangeFrame, -1000, 1000) must match the required frame specifiedwindowframe(RowFrame, -1, -1);
Review comment:
@dongjoon-hyun @HyukjinKwon According your discussion, I will revert this test case back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287652
**[Test build #117883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117883/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582283885
**[Test build #117908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117908/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582708615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22727/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r374443747
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
Review comment:
Because the query statements related to `empsalary` are currently in a comment state. I opened some comments for some of these queries and adjusted the statement and found no query results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581210072
**[Test build #117756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117756/testReport)** for PR 27439 at commit [`b792307`](https://github.com/apache/spark/commit/b792307cf3d8bd09779922bd390367b5abfd83ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581253978
**[Test build #117756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117756/testReport)** for PR 27439 at commit [`b792307`](https://github.com/apache/spark/commit/b792307cf3d8bd09779922bd390367b5abfd83ee).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582297532
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582756160
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117959/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582756152
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582687638
I'm expecting more PRs on `master`. However, for `branch-3.0`, I agree with you. You can optimize that from `branch-3.0` because we will not backport new feature~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375043228
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -8,12 +8,24 @@
--CONFIG_DIM1 spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=CODEGEN_ONLY
--CONFIG_DIM1 spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=NO_CODEGEN
-CREATE TABLE empsalary (
- depname string,
- empno integer,
- salary int,
- enroll_date date
-) USING parquet;
+-- CREATE TABLE empsalary (
+-- depname string,
+-- empno integer,
+-- salary int,
+-- enroll_date date
+--- ) USING parquet;
Review comment:
Is three `-` correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r374438128
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
Review comment:
It inserts data into `empsalary` table but why the queries below still show the same results?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375032802
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
Review comment:
OK. I created https://issues.apache.org/jira/browse/SPARK-30734 and will update PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582773145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117963/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582227461
> BTW, @beliefer, don't forget to update PR description and title accordingly.
Thanks for your reminder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582694503
If you plan to create a PRs to support them in this file, let's just don't comment `CREATE` and `INSERT` out here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375590662
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part2.sql.out
##########
@@ -72,17 +59,6 @@ struct<sum(unique1) OVER (PARTITION BY four ORDER BY unique1 ASC NULLS FIRST RAN
8 6 2
--- !query
-select last(salary) over(order by salary range between 1000 preceding and 1000 following),
-lag(salary) over(order by salary range between 1000 preceding and 1000 following),
-salary from empsalary
--- !query schema
-struct<>
--- !query output
-org.apache.spark.sql.AnalysisException
-Window Frame specifiedwindowframe(RangeFrame, -1000, 1000) must match the required frame specifiedwindowframe(RowFrame, -1, -1);
Review comment:
This query works fine in PostgreSQL. Sorry I missed some contexts in PostgreSQL test porting but shouldn't we match the results and queries?
The purpose of PostgreSQL in this query is positive but I wonder if it's right to change it to negative test case for this one alone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581254453
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117756/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287744
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117908/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582284289
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582283885
**[Test build #117908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117908/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375034167
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
+ ('develop', 10, 5200, date '2007-08-01'),
+ ('sales', 1, 5000, date '2006-10-01'),
+ ('personnel', 5, 3500, date '2007-12-10'),
+ ('sales', 4, 4800, date '2007-08-08'),
+ ('personnel', 2, 3900, date '2006-12-23'),
+ ('develop', 7, 4200, date '2008-01-01'),
+ ('develop', 9, 4500, date '2008-01-01'),
+ ('sales', 3, 4800, date '2007-08-01'),
+ ('develop', 8, 6000, date '2006-10-01'),
+ ('develop', 11, 5200, date '2007-08-15');
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582284289
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581210072
**[Test build #117756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117756/testReport)** for PR 27439 at commit [`b792307`](https://github.com/apache/spark/commit/b792307cf3d8bd09779922bd390367b5abfd83ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582756160
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117959/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582699155
**[Test build #117959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117959/testReport)** for PR 27439 at commit [`4e27e98`](https://github.com/apache/spark/commit/4e27e984e766e65b56243c9e036d7b4ad2b6a798).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582773137
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582297548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22684/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582284294
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22670/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582220158
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582543334
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582221476
**[Test build #117876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117876/testReport)** for PR 27439 at commit [`50d713e`](https://github.com/apache/spark/commit/50d713e9293aed183f496a29ad300049fed4a84d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582410100
**[Test build #117935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117935/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582284294
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22670/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582687964
Thanks @dongjoon-hyun. @beliefer, do you plan to support these soon? If that's the case let's bring `CREATE` and `INSERT` back here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582697522
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22723/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582282101
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581210320
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582543342
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117935/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582410100
**[Test build #117935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117935/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582282110
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117876/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582229128
**[Test build #117883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117883/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582297063
**[Test build #117921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117921/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582229383
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582229383
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582410598
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581872525
cc @dongjoon-hyun @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582542506
**[Test build #117935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117935/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582773137
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582297532
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581210324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22518/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582709866
**[Test build #117963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117963/testReport)** for PR 27439 at commit [`025c328`](https://github.com/apache/spark/commit/025c328bbb8ed252e30ab14b97749dadaa17d5bb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582756401
Merged to master, and branch-3.0 to match it with JIRA's
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582697509
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582297548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22684/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582398673
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117921/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375044935
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -8,12 +8,24 @@
--CONFIG_DIM1 spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=CODEGEN_ONLY
--CONFIG_DIM1 spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=NO_CODEGEN
-CREATE TABLE empsalary (
- depname string,
- empno integer,
- salary int,
- enroll_date date
-) USING parquet;
+-- CREATE TABLE empsalary (
+-- depname string,
+-- empno integer,
+-- salary int,
+-- enroll_date date
+--- ) USING parquet;
Review comment:
Uh， I not notice it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582410598
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582397939
**[Test build #117921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117921/testReport)** for PR 27439 at commit [`5929571`](https://github.com/apache/spark/commit/5929571c48c5f39eb3738428ef602a1e75a36888).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-581254444
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582287740
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582220158
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into
statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582398673
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117921/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582772568
**[Test build #117963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117963/testReport)** for PR 27439 at commit [`025c328`](https://github.com/apache/spark/commit/025c328bbb8ed252e30ab14b97749dadaa17d5bb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582709866
**[Test build #117963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117963/testReport)** for PR 27439 at commit [`025c328`](https://github.com/apache/spark/commit/025c328bbb8ed252e30ab14b97749dadaa17d5bb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582760629
@HyukjinKwon @dongjoon-hyun Thanks for your work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add
'insert into' statement of window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use test case and add 'insert into' statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582755613
**[Test build #117959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117959/testReport)** for PR 27439 at commit [`4e27e98`](https://github.com/apache/spark/commit/4e27e984e766e65b56243c9e036d7b4ad2b6a798).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375009397
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
Review comment:
I see one case being tested against `empsalary`
```sql
select last(salary) over(order by salary range between 1000 preceding and 1000 following),
lag(salary) over(order by salary range between 1000 preceding and 1000 following),
salary from empsalary;
```
```
-- !query
select last(salary) over(order by salary range between 1000 preceding and 1000 following),
lag(salary) over(order by salary range between 1000 preceding and 1000 following),
salary from empsalary
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Window Frame specifiedwindowframe(RangeFrame, -1000, 1000) must match the required frame specifiedwindowframe(RowFrame, -1, -1);
```
This isn't supported. Can you comment it out and make a followup JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org