You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/08/07 13:46:47 UTC
Review Request 68256: Added `LaunchNestedContainerSessionInParallel`
test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68256/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin Klues.
Bugs: MESOS-9116
https://issues.apache.org/jira/browse/MESOS-9116
Repository: mesos
Description
-------
This patch adds a test which verifies that launching multiple
short-lived nested container sessions succeeds. This test
implicitly verifies that agent correctly detects `mnt` namespace
of a command executor's task. If the detection fails, the
containerizer launcher (aka `nanny`) process fails to enter `mnt`
namespace, so it prints an error message into stderr for this
nested container.
This test is disabled until we fix MESOS-8545.
Diffs
-----
src/tests/api_tests.cpp 9c9fa9105a27ac7bb7f30d7eb67512d1e1d63d15
Diff: https://reviews.apache.org/r/68256/diff/1/
Testing
-------
Thanks,
Andrei Budnik
Re: Review Request 68256: Added
`LaunchNestedContainerSessionInParallel` test.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Aug. 17, 2018, 11:27 a.m., Alexander Rukletsov wrote:
> > src/tests/api_tests.cpp
> > Lines 6487 (patched)
> > <https://reviews.apache.org/r/68256/diff/2/?file=2072514#file2072514line6487>
> >
> > s/runs/run
> >
> > or maybe even:
> > ```
> > // Launch multiple nested container sessions each running a command which writes something to stdout and stderr and then exits.
> > ```
> >
> > Please also move this comment further below, e.g., to line 6498, while here—if you want, not really necessary—you can say you're gettign the parent container's id.
Fixed.
> On Aug. 17, 2018, 11:27 a.m., Alexander Rukletsov wrote:
> > src/tests/api_tests.cpp
> > Lines 6501 (patched)
> > <https://reviews.apache.org/r/68256/diff/2/?file=2072514#file2072514line6501>
> >
> > No magic values here please. Make declare it as `const int numContainers` at the beginning of the test.
Fixed.
> On Aug. 17, 2018, 11:27 a.m., Alexander Rukletsov wrote:
> > src/tests/api_tests.cpp
> > Lines 6505-6516 (patched)
> > <https://reviews.apache.org/r/68256/diff/2/?file=2072514#file2072514line6505>
> >
> > Maybe make a helper out of it to improve readability? Similar to, e.g., `createCallAccept()`. So that readers focus on passed parameters and less on the boilerplate code.
> >
> > Same for the snippet below.
Not sure if that helper can be applied anywhere outside of this particular function.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68256/#review207481
-----------------------------------------------------------
On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68256/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 1:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-9116
> https://issues.apache.org/jira/browse/MESOS-9116
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that launching multiple
> short-lived nested container sessions succeeds. This test
> implicitly verifies that agent correctly detects `mnt` namespace
> of a command executor's task. If the detection fails, the
> containerizer launcher (aka `nanny`) process fails to enter `mnt`
> namespace, so it prints an error message into stderr for this
> nested container.
>
> This test is disabled until we fix MESOS-8545.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 9c9fa9105a27ac7bb7f30d7eb67512d1e1d63d15
>
>
> Diff: https://reviews.apache.org/r/68256/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 68256: Added
`LaunchNestedContainerSessionInParallel` test.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68256/#review207481
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/api_tests.cpp
Lines 6487 (patched)
<https://reviews.apache.org/r/68256/#comment290875>
s/runs/run
or maybe even:
```
// Launch multiple nested container sessions each running a command which writes something to stdout and stderr and then exits.
```
Please also move this comment further below, e.g., to line 6498, while here—if you want, not really necessary—you can say you're gettign the parent container's id.
src/tests/api_tests.cpp
Lines 6501 (patched)
<https://reviews.apache.org/r/68256/#comment290877>
No magic values here please. Make declare it as `const int numContainers` at the beginning of the test.
src/tests/api_tests.cpp
Lines 6505-6516 (patched)
<https://reviews.apache.org/r/68256/#comment290879>
Maybe make a helper out of it to improve readability? Similar to, e.g., `createCallAccept()`. So that readers focus on passed parameters and less on the boilerplate code.
Same for the snippet below.
- Alexander Rukletsov
On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68256/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 1:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-9116
> https://issues.apache.org/jira/browse/MESOS-9116
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that launching multiple
> short-lived nested container sessions succeeds. This test
> implicitly verifies that agent correctly detects `mnt` namespace
> of a command executor's task. If the detection fails, the
> containerizer launcher (aka `nanny`) process fails to enter `mnt`
> namespace, so it prints an error message into stderr for this
> nested container.
>
> This test is disabled until we fix MESOS-8545.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 9c9fa9105a27ac7bb7f30d7eb67512d1e1d63d15
>
>
> Diff: https://reviews.apache.org/r/68256/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>