You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/02/18 05:52:02 UTC

[GitHub] [incubator-doris] yangzhg opened a new pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

yangzhg opened a new pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132


   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   fix check_fn and fn_call function name not same
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (No)
   2. Has unit tests been added: (No Need)
   3. Has document been added or modified: (No Need)
   4. Does it need to update dependencies: (No)
   5. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132#issuecomment-1046783452






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on a change in pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132#discussion_r810126909



##########
File path: gensrc/proto/function_service.proto
##########
@@ -35,8 +35,8 @@ message PFunctionCallRequest {
 }
 
 message PFunctionCallResponse {
-    optional PValues result = 1;
-    optional PStatus status = 2;
+    required PValues result = 1;

Review comment:
       why changing to requried?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yangzhg commented on pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132#issuecomment-1045803505


   > It's better to forbidden use required field in Thrift or ProtocolBuffer. We could not remove it in the future and there will be a lot of rubbish code. For example, version hash, schema hash.... It is too terrible!!!!!
   
   I have removed required
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yangzhg merged pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei commented on pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

Posted by GitBox <gi...@apache.org>.
yiguolei commented on pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132#issuecomment-1045708220


   It's better to forbidden use required field in Thrift or ProtocolBuffer. We could not remove it in the future and there will be a lot of rubbish code. For example, version hash, schema hash.... It is too terrible!!!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132#discussion_r810443066



##########
File path: gensrc/proto/function_service.proto
##########
@@ -35,8 +35,8 @@ message PFunctionCallRequest {
 }
 
 message PFunctionCallResponse {
-    optional PValues result = 1;
-    optional PStatus status = 2;
+    required PValues result = 1;

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] stalary commented on a change in pull request #8132: [fix] (udf) fix check_fn and fn_call function name not same

Posted by GitBox <gi...@apache.org>.
stalary commented on a change in pull request #8132:
URL: https://github.com/apache/incubator-doris/pull/8132#discussion_r810420103



##########
File path: gensrc/proto/function_service.proto
##########
@@ -35,8 +35,8 @@ message PFunctionCallRequest {
 }
 
 message PFunctionCallResponse {
-    optional PValues result = 1;
-    optional PStatus status = 2;
+    required PValues result = 1;

Review comment:
       During the test, I found that forgetting to return would lead to be crash




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org