You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/03/07 05:15:44 UTC
[GitHub] [avro] dependabot[bot] opened a new pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
dependabot[bot] opened a new pull request #1126:
URL: https://github.com/apache/avro/pull/1126
Bumps [System.Reflection.Emit.Lightweight](https://github.com/dotnet/corefx) from 4.3.0 to 4.7.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dotnet/corefx/releases">System.Reflection.Emit.Lightweight's releases</a>.</em></p>
<blockquote>
<h2>.NET Core 2.1.0 RC1</h2>
<ul>
<li><a href="https://github.com/dotnet/core/blob/master/release-notes/2.1/Preview/2.1.0-rc1.md">Release Notes</a></li>
<li><a href="https://github.com/dotnet/core/blob/master/release-notes/2.1/Preview/2.1.0-rc1-known-issues.md">Known Issues</a></li>
<li><a href="https://github.com/dotnet/core/blob/master/release-notes/download-archives/2.1.0-rc1-download.md">Download and Install</a></li>
</ul>
<h2>Repos</h2>
<ul>
<li><a href="https://github.com/dotnet/coreclr/releases/tag/v2.1-rc1">CoreCLR</a></li>
<li><a href="https://github.com/dotnet/corefx/releases/tag/v2.1-rc1">CoreFX</a></li>
<li><a href="https://github.com/dotnet/core-setup/releases/tag/v2.1-rc1">Core-Setup</a></li>
<li><a href="https://github.com/dotnet/cli/releases/tag/v2.1.300-rc1-008673">CLI</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/dotnet/corefx/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1027290974
That makes more sense. Should have looked at the file comments. I will need to check into the package history to see if there are any underlying bugs that may have been fixed that benefits an update. Same with Newtonsoft.Json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1027279840
I didn't merge this one because of this comment few lines above:
```
<!--
These package versions are the bare minimum requriement. Only update the version of these dependencies,
if functionality requires it. Leave it up to the users of the library as to whether or not they want the
latest and greatest of a particularly dependency.
!!! ONLY UPDATE IF FUNCTIONALITY REQUIRES IT !!!
-->
```
@zcsizmadia What's your opinion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1008811196
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1027295109
https://github.com/apache/avro/commit/2a0c2638d13154e839d5cb4c438ecf67afba88b4#diff-940d06f8f7ef5f132b259bdf8d271404a2ba624ffe78d14fc9f714f5799f6b05 already bumped one of them.
Maybe we should only have minimal version for Newtonsoft and not the other. That would make it more clear. (and maybe add the chat as a link to the comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1027506714
Thanks @zcsizmadia I didn't get a chance to dig into it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] dkulp commented on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
dkulp commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-918505660
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1027291766
This is the original concern we had a good while ago: https://github.com/apache/avro/pull/981#pullrequestreview-533018009
The idea was that any tool, e.g. codegen is built with the latest versions, however the libs are not bumped automatically to avoid any collisions with mismatching versions. The concern IIRC was very specific to Newtonsoft json and not the others.
My call would be go for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1126: AVRO-3351: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1126:
URL: https://github.com/apache/avro/pull/1126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia edited a comment on pull request #1126: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1027295109
https://github.com/apache/avro/commit/2a0c2638d13154e839d5cb4c438ecf67afba88b4#diff-940d06f8f7ef5f132b259bdf8d271404a2ba624ffe78d14fc9f714f5799f6b05 already bumped one of them.
Maybe we should only have minimal version for Newtonsoft and not the others. That would make it more clear. (and maybe add the chat as a link to the comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1126: AVRO-3351: Bump System.Reflection.Emit.Lightweight from 4.3.0 to 4.7.0 in /lang/csharp
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1126:
URL: https://github.com/apache/avro/pull/1126#issuecomment-1027675660
> Maybe we should only have minimal version for Newtonsoft and not the others. That would make it more clear. (and maybe add the chat as a link to the comments)
Done with 4138f45f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org