[GitHub] [iceberg] rdblue commented on a diff in pull request #5638: Bind overwrite filters

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5638:
URL: https://github.com/apache/iceberg/pull/5638#discussion_r956790093


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java:
##########
@@ -119,7 +121,24 @@ public WriteBuilder overwrite(Filter[] filters) {
         !overwriteFiles, "Cannot overwrite individual files and using filters");
     Preconditions.checkState(rewrittenFileSetId == null, "Cannot overwrite and rewrite");
 
-    this.overwriteExpr = SparkFilters.convert(filters);
+    boolean caseSensitive = Boolean.parseBoolean(spark.conf().get("spark.sql.caseSensitive"));
+    overwriteExpr = Expressions.alwaysTrue();
+    for (Filter filter : filters) {

Review Comment:
   Can you update the `convert(Filter[])` method rather than moving so much of the logic here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org