[GitHub] [spark] srowen commented on a diff in pull request #42999: [SPARK-45217][CORE] Support change log level of specific package or class

["srowen (via GitHub)" <gi...@apache.org>]

srowen commented on code in PR #42999:
URL: https://github.com/apache/spark/pull/42999#discussion_r1337449084


##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -401,6 +402,23 @@ class SparkContext(config: SparkConf) extends Logging {
     }
   }
 
+  /** Change logLevel of specific package or class name.
+   *  This overrides any user-defined log settings.
+   *
+   * @param loggerName package or class name such as "org.apache.spark" or
+   *                   "org.apache.spark.SparkContext"
+   * @param logLevel The desired log level as a string.
+   *                 Valid log levels include: ALL, DEBUG, ERROR, FATAL, INFO, OFF, TRACE, WARN
+   */

Review Comment:
   Need the "since 4.0.0" on the new methods



##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -401,6 +402,23 @@ class SparkContext(config: SparkConf) extends Logging {
     }
   }
 
+  /** Change logLevel of specific package or class name.
+   *  This overrides any user-defined log settings.
+   *
+   * @param loggerName package or class name such as "org.apache.spark" or
+   *                   "org.apache.spark.SparkContext"
+   * @param logLevel The desired log level as a string.
+   *                 Valid log levels include: ALL, DEBUG, ERROR, FATAL, INFO, OFF, TRACE, WARN
+   */

Review Comment:
   We need this in Pyspark, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org