You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/11/03 08:01:39 UTC
[GitHub] [netbeans] mbien opened a new pull request #3299: Document switcher popup not grouping by project on first use.
mbien opened a new pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299
issue:
1) tools -> options -> appearance -> doc tabs -> check sort opened docs by project
2) open some files, open the tab switcher popup on the upper right corner of the editor
3) you will notice first open does not group by projects as requested
4) open it again... should work now
fix for document switcher popup not grouping by project on first use:
- getProjectForTab() is an async query returning null on first run but
notifies over new results over property change events.
- ButtonPopupSwitcher did not register any property change listeners.
- registering it as listener requires event debouncing to avoid
repaints in bursts (can be easily 50 events at once).
I don't like that i had to add to the complexity to fix this. I would rather just remove the async code:
```diff
diff --git a/ide/core.multitabs.project/src/org/netbeans/core/multitabs/project/ProjectSupportImpl.java b/ide/core.multitabs.project/src/org/netbeans/core/multitabs/project/ProjectSupportImpl.java
index 934f207..9a7f701 100644
--- a/ide/core.multitabs.project/src/org/netbeans/core/multitabs/project/ProjectSupportImpl.java
+++ b/ide/core.multitabs.project/src/org/netbeans/core/multitabs/project/ProjectSupportImpl.java
@@ -111,24 +111,12 @@
synchronized( file2project ) {
p = file2project.get(fo);
if( null == p ) {
- if( currentQueries.contains(fo) ) {
- //there already is a file owner query for this file
- return null;
- } else {
- currentQueries.add(fo);
- RP.post(new Runnable() {
- @Override
- public void run() {
- Project p = FileOwnerQuery.getOwner( fo );
- if( null != p ) {
- synchronized( file2project ) {
- file2project.put( fo, p );
- currentQueries.remove(fo);
- }
- changeSupport.fireChange();
- }
- }
- });
+ p = FileOwnerQuery.getOwner( fo );
+ if( null != p ) {
+ synchronized( file2project ) {
+ file2project.put( fo, p );
+ }
+ changeSupport.fireChange();
}
}
}
```
I don't think `FileOwnerQuery.getOwner( fo )` is heavyweight enough to justify async actions in inner loop code. I tested it with about 50 opened files from different projects and it still opened very fast on first open after IDE start. All the async code with its overhead might not be needed.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-959268431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-991597606
I was using NetBeans with this fix daily for one week without any problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-991597606
I was using NetBeans with this fix daily for one week without any problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-1008221649
changed the impl as previously discussed to make it less risky. (decoupled from EDT on a higher level, one task for all tabs with timeout)
edit: for manual testing try to set a breakpoint inside the task, eg. there: https://github.com/apache/netbeans/pull/3299/files#diff-793eded4bbc5a3b7a16c8d300f53f467eb7538137d6d7338a36c433cf11473daR73 and then open the tab switcher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-959219170
@mbien I tested this fix with PHP project - it fixes first use after loading IDE.
Newly opened files are still sorted under "no project" and switcher has to be closed and opened again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-963228627
@mbien I'm not sure about integrating this in to the 12.6 release, but also not investigated the changes in detail. Does this move the project resolution via FileOwnerQuery on to the EDT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-1014476897
@mbien I say, feel free to merge it so we get it in 13-rc1. I would normally be inclined to trigger back to the EDT via invokeLater with something like this. But here, this should be fine, and I suspect with any open tabs the information is already calculated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-963228627
@mbien I'm not sure about integrating this in to the 12.6 release, but also not investigated the changes in detail? Does this move the project resolution via FileOwnerQuery on to the EDT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-1014476897
@mbien merging so we get it in 13-rc1. I would normally be inclined to trigger back to the EDT via invokeLater with something like this. But here, this should be fine, and I suspect with any open tabs the information is already calculated as you said earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-959268431
@KacerCZ ah interesting. Going to take a look at this case tomorrow. I might just add another commit which removes the async code. I could probably test it by putting a project on a usb drive or something similar.
Thanks for linking the issue to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-1008221649
changed the impl as previously discussed to make it less risky. (decoupled from EDT on a higher level, one task for all tabs with timeout)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3299: Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-959052927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3299: Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-959052927
@mbien I filed this issue some time ago as https://issues.apache.org/jira/browse/NETBEANS-5209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-963279933
> @mbien I'm not sure about integrating this in to the 12.6 release, but also not investigated the changes in detail. Does this move the project resolution via FileOwnerQuery on to the EDT?
yes. but at this point everything should be already in the cache. I had about 100 projects open and opened one file per project and the switcher appeared basically right away after IDE start.
If you look at the doc of FileOwnerQueryImplementation:
https://github.com/apache/netbeans/blob/c084119009d2e0f736f225d706bc1827af283501/ide/projectapi/src/org/netbeans/spi/project/FileOwnerQueryImplementation.java#L27-L29
If it is still determined that it still needs to be off EDT i would probably try to decouple it a few layers higher, e.g https://github.com/apache/netbeans/blob/cf6c1a8d4ec0e2faca0b6143cf8cef928bc00d94/platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ButtonPopupSwitcher.java#L455
to avoid getting barraged by property change events fired from inner loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-960536345
ca3c620 has the async logic removed. Updated PR text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-959268431
@KacerCZ ah interesting. Going to take a look at this case tomorrow. I might just add another commit which removes the async code. I could probably test it by putting a project on a usb drive or something similar.
Thanks for linking the issue to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-960570190
I'm happy to confirm that after last commit the issue seems to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-963371515
no need to rush anything. I rebased most of my bugfix PRs just in case someone wants to integrate them while i am not available. Lets get 12.6 released ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-965074508
OK, punting this to NB13 as no-one has reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-1014476897
@mbien merging so we get it in 13-rc1. I would normally be inclined to trigger back to the EDT via invokeLater with something like this. But here, this should be fine, and I suspect with any open tabs the information is already calculated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] netbeansuser2019 commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
netbeansuser2019 commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-973960786
Great, finally you pick NETBEANS-3752 up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3299: Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-959052927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-962387185
rebased onto delivery, since I saw there will be a RC 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-1014003094
@matthiasblaesing @neilcsmith-net @timboudreau any opinions on this. The code which unblocks the EDT is here
https://github.com/apache/netbeans/commit/92619c994a009165c7c37da441a81203b34701b6#diff-793eded4bbc5a3b7a16c8d300f53f467eb7538137d6d7338a36c433cf11473daR80
The task is usually done in <10ms. Fallback would be no groups in the popup on time out - but this does not happen under normal operation. This is purely there to ensure that the EDT can in fact not be blocked indefinitely, without having to review the entire implementation behind the project lookup logic for this minor fix (there is a lot of caching going on there).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3299: [NETBEANS-5209] Document switcher popup not grouping by project on first use.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3299:
URL: https://github.com/apache/netbeans/pull/3299#issuecomment-963365197
Yes, I read the docs and looked at a couple of the implementations. I'm not sure if there might be edge cases that could lock up the EDT or not here. I presume it was made async for a reason. I also agree that moving up a few layers would make more sense.
In terms of 12.6, going to request review - I'm not making the call on whether to merge, but it seems a slightly risky one to me at this stage when we're hoping this will be the final release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists