You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/10 09:04:10 UTC

[GitHub] [camel] davsclaus commented on a change in pull request #4409: CAMEL-15664: Automatically wrap secret properites with RAW when computing the URI

davsclaus commented on a change in pull request #4409:
URL: https://github.com/apache/camel/pull/4409#discussion_r502767255



##########
File path: core/camel-support/src/main/java/org/apache/camel/support/component/EndpointUriFactorySupport.java
##########
@@ -78,6 +79,20 @@ protected String buildQueryParameters(String uri, Map<String, Object> parameters
             throws URISyntaxException {
         // we want sorted parameters
         Map<String, Object> map = new TreeMap<>(parameters);
+        map.replaceAll(new BiFunction<String, Object, Object>() {

Review comment:
       Isnt there a way to do this faster, eg now you replace all values? What if there are no secrets at all? Wont it be faster just to walk on the secret property names, and see if they are in the parameters, and then only replace those.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org