[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2556: [engine][checkpoint] checkpoint flow

[GitBox <gi...@apache.org>]

ashulin commented on code in PR #2556:
URL: https://github.com/apache/incubator-seatunnel/pull/2556#discussion_r957952156


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/operation/CheckpointFinishedOperation.java:
##########
@@ -50,21 +51,23 @@ public int getClassId() {
 
     @Override
     protected void writeInternal(ObjectDataOutput out) throws IOException {
-        out.writeLong(jobId);
-        out.writeLong(pipelineId);
         out.writeLong(checkpointId);
+        out.writeObject(taskInfo);
+        out.writeBoolean(successful);
     }
 
     @Override
     protected void readInternal(ObjectDataInput in) throws IOException {
-        jobId = in.readLong();
-        pipelineId = in.readLong();
         checkpointId = in.readLong();
+        taskInfo = in.readObject(TaskInfo.class);
+        successful = in.readBoolean();
     }
 
     @Override
     protected PassiveCompletableFuture<?> doRun() throws Exception {
-        // TODO: Notifies all tasks of the pipeline about the status of the checkpoint
+        SeaTunnelServer server = getService();
+        Task task = server.getTaskExecutionService().getExecutionContext(taskInfo.getTaskGroupId())

Review Comment:
   thx, done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org