You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/18 12:09:13 UTC
[GitHub] [spark] cloud-fan opened a new pull request #27619: revert
SPARK-29663 and SPARK-29688
cloud-fan opened a new pull request #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR reverts https://github.com/apache/spark/pull/26325 and https://github.com/apache/spark/pull/26347
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When we do sum/avg, we need a wider type of input to hold the sum value, to reduce the possibility of overflow. For example, we use long to hold the sum of integral inputs, use double to hold the sum of float/double.
However, we don't have a wider type of interval. Also the semantic is unclear: what if the days field overflows but the months field doesn't? Currently the avg of `1 month` and `2 month` is `1 month 15 days`, which assumes 1 month has 30 days and we should avoid this assumption.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
yes, remove 2 features added in 3.0
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587472152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118633/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27619: revert SPARK-29663 and
SPARK-29688
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587430531
cc @yaooqinn @hvanhovell @maryannxue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587472136
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587669800
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587669800
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587431286
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587431290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23386/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27619:
revert SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#discussion_r381081689
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -957,17 +957,4 @@ class DataFrameAggregateSuite extends QueryTest
assert(error.message.contains("function count_if requires boolean type"))
}
}
-
- test("calendar interval agg support hash aggregate") {
Review comment:
support interval in `UnsafeRow` is fine. It has perf benefits, not just for hash aggregate, so we shouldn't revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27619:
revert SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#discussion_r381459749
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -957,17 +957,4 @@ class DataFrameAggregateSuite extends QueryTest
assert(error.message.contains("function count_if requires boolean type"))
}
}
-
- test("calendar interval agg support hash aggregate") {
Review comment:
Yes, I'm not asking to revert SPARK-30047. I'm saying that it would be great if this PR title and description mentioned this clearly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587472136
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587488146
**[Test build #118642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118642/testReport)** for PR 27619 at commit [`b25e491`](https://github.com/apache/spark/commit/b25e491bef4441e4f0f7fabfdc08e60e3a36c4b5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27619:
revert SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#discussion_r381743821
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -957,17 +957,4 @@ class DataFrameAggregateSuite extends QueryTest
assert(error.message.contains("function count_if requires boolean type"))
}
}
-
- test("calendar interval agg support hash aggregate") {
Review comment:
Added to the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
hvanhovell closed pull request #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587431286
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587472152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118633/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27619: revert SPARK-29663 and
SPARK-29688
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587488146
**[Test build #118642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118642/testReport)** for PR 27619 at commit [`b25e491`](https://github.com/apache/spark/commit/b25e491bef4441e4f0f7fabfdc08e60e3a36c4b5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587431290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23386/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27619:
revert SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#discussion_r380920075
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -957,17 +957,4 @@ class DataFrameAggregateSuite extends QueryTest
assert(error.message.contains("function count_if requires boolean type"))
}
}
-
- test("calendar interval agg support hash aggregate") {
Review comment:
Hi, @cloud-fan .
Although this is a correct removal, this is a part of `[SPARK-30047][SQL] Support interval types in UnsafeRow`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27619: revert SPARK-29663 and
SPARK-29688
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587471915
**[Test build #118633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118633/testReport)** for PR 27619 at commit [`8ffc9eb`](https://github.com/apache/spark/commit/8ffc9eba0988f10fc1fa1e3e400794a98e77ce62).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587669843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118642/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587488772
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23395/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587430753
**[Test build #118633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118633/testReport)** for PR 27619 at commit [`8ffc9eb`](https://github.com/apache/spark/commit/8ffc9eba0988f10fc1fa1e3e400794a98e77ce62).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587778040
Merging to master/branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587488755
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27619: revert SPARK-29663
and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587488772
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23395/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27619: revert SPARK-29663 and
SPARK-29688
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587430753
**[Test build #118633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118633/testReport)** for PR 27619 at commit [`8ffc9eb`](https://github.com/apache/spark/commit/8ffc9eba0988f10fc1fa1e3e400794a98e77ce62).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27619: revert SPARK-29663 and
SPARK-29688
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587667090
**[Test build #118642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118642/testReport)** for PR 27619 at commit [`b25e491`](https://github.com/apache/spark/commit/b25e491bef4441e4f0f7fabfdc08e60e3a36c4b5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587488755
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27619:
revert SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#discussion_r380920075
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -957,17 +957,4 @@ class DataFrameAggregateSuite extends QueryTest
assert(error.message.contains("function count_if requires boolean type"))
}
}
-
- test("calendar interval agg support hash aggregate") {
Review comment:
Hi, @cloud-fan .
Although this is a correct removal, this is a part of `[SPARK-30047][SQL] Support interval types in UnsafeRow` which is not aimed in the PR title and description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27619: revert
SPARK-29663 and SPARK-29688
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27619: revert SPARK-29663 and SPARK-29688
URL: https://github.com/apache/spark/pull/27619#issuecomment-587669843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118642/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org