You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/30 14:56:34 UTC

[GitHub] [rocketmq-externals] zhangjidi2016 commented on a change in pull request #753: [ISSUE #673] Add unit tests for DashBoardController.

zhangjidi2016 commented on a change in pull request #753:
URL: https://github.com/apache/rocketmq-externals/pull/753#discussion_r679990341



##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/service/impl/DashboardCollectServiceImpl.java
##########
@@ -45,7 +45,7 @@
 public class DashboardCollectServiceImpl implements DashboardCollectService {
 
     @Resource
-    private RMQConfigure rmqConfigure;
+    private RMQConfigure rMQConfigure;

Review comment:
       > It's a little wordy for rmq or rMQ..., you can leave it out. Rename it configure directly
   
   We defined rMQConfigure in BaseControllerTest, and all subsequent unit test classes inherited this BaseControllerTest. In order to reuse this, we changed it to rMQConfigure. 
   In order to maintain unity，I'll revise it，all references in projects are directly modified to configure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org