[GitHub] [pulsar] merlimat commented on a change in pull request #4348: Support max message size for cpp and go client

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4348: Support max message size for cpp and go client
URL: https://github.com/apache/pulsar/pull/4348#discussion_r288271841
 
 

 ##########
 File path: pulsar-client-cpp/lib/Commands.h
 ##########
 @@ -49,7 +49,7 @@ class Commands {
     };
     enum WireFormatConstant
     {
-        MaxMessageSize = (5 * 1024 * 1024 - (10 * 1024)),
+        DefaultMaxMessageSize = (5 * 1024 * 1024 - (10 * 1024)),
         MaxFrameSize = (5 * 1024 * 1024)
 
 Review comment:
   We should making sure these are aligned with the constants in Java. Eg. there we have 5Mb max msg size with an additional padding of 10K on top of it for the frame size.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services