[hop] branch master updated: Updated ExcelWriterTransform to use posY relative to the starting cell provided, where provided.

[ha...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new f6634bc021 Updated ExcelWriterTransform to use posY relative to the starting cell provided, where provided.
     new 22fcbd19bb Merge pull request #2540 from dameikle/excel_start_cell
f6634bc021 is described below

commit f6634bc021598e1469f7c05f204eb0eec400d401
Author: David Meikle <da...@meikle.io>
AuthorDate: Thu Mar 9 22:54:04 2023 +0000

    Updated ExcelWriterTransform to use posY relative to the starting cell provided, where provided.
---
 .../hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java b/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java
index 9e3b038706..083bd80007 100644
--- a/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java
+++ b/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java
@@ -980,9 +980,12 @@ public class ExcelWriterTransform
       } else {
         baseFileName = file.getName().toString();
       }
+
+      // If starting cell provided, use the posY derived above, otherwise use default behaviour
+      int startY = !Utils.isEmpty(data.realStartingCell) ? posY : Math.max(posY, sheet.getLastRowNum());
+
       ExcelWriterWorkbookDefinition workbookDefinition =
-          new ExcelWriterWorkbookDefinition(
-              baseFileName, file, wb, sheet, posX, Math.max(posY, sheet.getLastRowNum()));
+          new ExcelWriterWorkbookDefinition(baseFileName, file, wb, sheet, posX, startY);
       workbookDefinition.setSplitNr(splitNr);
       data.usedFiles.add(workbookDefinition);
       data.currentWorkbookDefinition = workbookDefinition;