You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/11/23 15:15:03 UTC
Review Request 40596: Bunch of unit tests fail with JDK 1.8
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40596/
-----------------------------------------------------------
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-14013
https://issues.apache.org/jira/browse/AMBARI-14013
Repository: ambari
Description
-------
Some analysis:
1. ViewRegistryTest and ClientConfigResourceProviderTest - fail due to incompatible versions of cglib and ASM (used by PowerMock). cglib should be updated to 3.2, ASM dep should be dropped in flavor of implicit one.
2. ExecutionCommandWrapperTest - this one is testing config override functionality dropped in July 2013. Current behavior is different, but because of some luck with HashMap ordering test still passed. I assume that String.hashCode/HashMap implementation was changed in JDK 1.8 which resulted in different ordering and test fail.
Some other fails with similar reason present also.
Diffs
-----
ambari-project/pom.xml f4ba977
ambari-server/pom.xml c76629a
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 75e6f75
ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java 25b477f
ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java 2ea45dc
ambari-server/src/test/java/org/apache/ambari/server/controller/AuthToLocalBuilderTest.java cbcffe6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java b610d8e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java d5f0395
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java d7b1c39
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java eafa2a5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java 4c8892e
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java 98de9cf
ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java 47c8e53
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java 8ab4ba1
ambari-server/src/test/java/org/apache/ambari/server/update/HostUpdateHelperTest.java 0755674
ambari-server/src/test/java/org/apache/ambari/server/utils/CollectionPresentationUtils.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java 9be6e4f
ambari-server/src/test/java/org/apache/ambari/server/view/validation/InstanceValidationResultImplTest.java b375cd2
Diff: https://reviews.apache.org/r/40596/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 40596: Bunch of unit tests fail with JDK 1.8
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40596/#review107585
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Лис. 23, 2015, 4:15 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40596/
> -----------------------------------------------------------
>
> (Updated Лис. 23, 2015, 4:15 після полудня)
>
>
> Review request for Ambari and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-14013
> https://issues.apache.org/jira/browse/AMBARI-14013
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some analysis:
>
> 1. ViewRegistryTest and ClientConfigResourceProviderTest - fail due to incompatible versions of cglib and ASM (used by PowerMock). cglib should be updated to 3.2, ASM dep should be dropped in flavor of implicit one.
> 2. ExecutionCommandWrapperTest - this one is testing config override functionality dropped in July 2013. Current behavior is different, but because of some luck with HashMap ordering test still passed. I assume that String.hashCode/HashMap implementation was changed in JDK 1.8 which resulted in different ordering and test fail.
> Some other fails with similar reason present also.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml f4ba977
> ambari-server/pom.xml c76629a
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 75e6f75
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java 25b477f
> ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java 2ea45dc
> ambari-server/src/test/java/org/apache/ambari/server/controller/AuthToLocalBuilderTest.java cbcffe6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java b610d8e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java d5f0395
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java d7b1c39
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java eafa2a5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java 4c8892e
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java 98de9cf
> ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java 47c8e53
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java 8ab4ba1
> ambari-server/src/test/java/org/apache/ambari/server/update/HostUpdateHelperTest.java 0755674
> ambari-server/src/test/java/org/apache/ambari/server/utils/CollectionPresentationUtils.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java 9be6e4f
> ambari-server/src/test/java/org/apache/ambari/server/view/validation/InstanceValidationResultImplTest.java b375cd2
>
> Diff: https://reviews.apache.org/r/40596/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>