[jira] Commented: (JCR-2224) Change access levels in SearchIndex and NodeIndexer for better inherance

["Marcel Reutegger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734566#action_12734566 ] 

Marcel Reutegger commented on JCR-2224:
---------------------------------------

Why is it needed to change the visibility of NodeIndexer.createDoc() to public? A subclass is able to see that method even if it is in another package and IIUC that's what you are doing. 

> Change access levels in SearchIndex and NodeIndexer for better inherance
> ------------------------------------------------------------------------
>
>                 Key: JCR-2224
>                 URL: https://issues.apache.org/jira/browse/JCR-2224
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.5.6, 2.0-alpha4
>            Reporter: Sébastien Launay
>            Priority: Trivial
>         Attachments: JCR-2224-2009-07-23.patch
>
>
> I want to change NodeIndexer#addBinaryValue logic in JR 1.5.6, therefore i needed to:
> * create a custom class extending NodeIndexer for changing binary field indexation
> * create a custom class extending SearchIndex for using this custom NodeIndexer
> I was obliged to:
> * override SearchIndex#createTextExtractor in order to store created TextExtractor because of private attribute
> * put both classes into package org.apache.jackrabbit.core.query.lucene because NodeIndexer#createDoc(...) is protected
> In trunk TextExtractor has now a getter but there are still some private attributes.
> And NodeIndexer#createDoc(...) is still protected and there are some private methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.