You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/01 02:14:12 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #2953: fix stackoverflow when parse plan failed

neuyilan commented on a change in pull request #2953:
URL: https://github.com/apache/iotdb/pull/2953#discussion_r605331777



##########
File path: cross-tests/src/test/java/org/apache/iotdb/cross/tests/tools/importCsv/ExportCsvTestIT.java
##########
@@ -46,6 +46,22 @@
 
   private final String EXPORT_FILE = "target" + File.separator + "dump0.csv";
 
+  private final String[] outputForWindows = {
+    "------------------------------------------",
+    "Starting IoTDB Client Export Script",
+    "------------------------------------------",
+    "Start to export data from sql statement",
+    "successfully",
+  };
+
+  private final String[] outputForUnix = {
+    "------------------------------------------",
+    "Starting IoTDB Client Export Script",
+    "------------------------------------------",
+    "Start to export data from sql statement",
+    "successfully",
+  };
+

Review comment:
       Can we combine the `outputForWindows` and `outputForUnix` together? as I see the string arrays are the same.
   
   And the same as others.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org