You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/27 16:42:28 UTC

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11446: feat: annotations list CRUD view

dpgaspar commented on a change in pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#discussion_r512853328



##########
File path: superset/annotation_layers/annotations/api.py
##########
@@ -99,12 +100,13 @@ class AnnotationRestApi(BaseSupersetModelRestApi):
     edit_model_schema = AnnotationPutSchema()
     edit_columns = add_columns
     order_columns = [
-        "short_descr",
-        "created_by.first_name",
         "changed_by.first_name",
         "changed_on_delta_humanized",
-        "start_dttm",
+        "created_by.first_name",
         "end_dttm",
+        "long_descr",
+        "short_descr",
+        "start_dttm",

Review comment:
       cool! thank you




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org