[jira] [Commented] (SOLR-7710) replace various "async" with CommonAdminParams.ASYNC

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595949#comment-14595949 ] 

ASF GitHub Bot commented on SOLR-7710:
--------------------------------------

GitHub user cpoerschke opened a pull request:

    https://github.com/apache/lucene-solr/pull/156

    SOLR-7710: replace various "async" with CommonAdminParams.ASYNC

    for https://issues.apache.org/jira/i#browse/SOLR-7710

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/lucene-solr trunk-ocp-async

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 0fc933164c89c65c721857cba4c1921e86b3aeb2
Author: Christine Poerschke <cp...@bloomberg.net>
Date:   2015-04-29T18:26:46Z

    SOLR-????: replace various "async" with CommonAdminParams.ASYNC
    
    This change turns
      org.apache.solr.cloud.OverseerCollectionProcessor.ASYNC
    into
      org.apache.solr.common.params.CommonAdminParams.ASYNC
    and then uses it in various places (instead of "async").
    
    The commit also adds a CommonAdminParamsTest to test the backwards compatibility of CommonAdminParams parameter constants. If someone accidentally changes those constants then the test will flag that up.

----


> replace various "async" with CommonAdminParams.ASYNC
> ----------------------------------------------------
>
>                 Key: SOLR-7710
>                 URL: https://issues.apache.org/jira/browse/SOLR-7710
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> * github pull request with proposed changes to follow shortly.
> * Motivation is addition of a test case for an unrelated change (not yet uploaded) and not wishing to add literally {{"async"}} in that test case. Using {{CommonAdminParams.ASYNC}} instead of "async" can also make code base 'navigation' a little easier e.g. locating of existing test cases.
> * The proposed change also adds a little {{CommonAdminParamsTest}} to test the backwards compatibility of CommonAdminParams parameter constants i.e. if someone accidentally changes those constants then the test will flag that up. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org