You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/12 12:33:02 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

lhotari opened a new pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193


   ### Motivation
   
   PrometheusMetricsTest has been flaky with this type of error mesage:
   `java.lang.AssertionError: line pulsar_broker_publish_latency{cluster="test",quantile="0.0"} +Inf does not match pattern ^(\w+)\{([^\}]+)\}\s(-?[\d\w\.-]+)(\s(\d+))?$ expected [true] but found [false]`
   The problem is that the metrics parsing hasn't properly handled `+Inf` which is used as a value when there are no metrics.
   
   ### Modifications
   
   Fix the regex pattern to handle `+Inf` and add tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-818233906


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-817998777


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-817904555


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-817943655


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-817904555






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-818319331


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-818319331


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-818233906


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10193: [Tests] Fix Prometheus metrics parsing for "+Inf" in PrometheusMetricsTest and Pulsar Function tests

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10193:
URL: https://github.com/apache/pulsar/pull/10193#issuecomment-818395305


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org