[incubator-hop] branch master updated: HOP-3310 - UserDefinedJavaClass - Error initializing UserDefinedJavaClass to get fields HOP-3309 - UserDefinedJavaClass - i18n issue clicking on editor area

[mc...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mcasters pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hop.git


The following commit(s) were added to refs/heads/master by this push:
     new 66f1e17  HOP-3310 - UserDefinedJavaClass - Error initializing UserDefinedJavaClass to get fields HOP-3309 - UserDefinedJavaClass - i18n issue clicking on editor area
     new a8dfce1  Merge pull request #1084 from sramazzina/UDJC-SANDBOX
66f1e17 is described below

commit 66f1e17fdb32d08f1233b0be8bf1e8acc8986c83
Author: sergio.ramazzina <se...@serasoft.it>
AuthorDate: Mon Sep 27 12:27:34 2021 +0200

    HOP-3310 - UserDefinedJavaClass - Error initializing UserDefinedJavaClass to get fields
    HOP-3309 - UserDefinedJavaClass - i18n issue clicking on editor area
---
 .../UserDefinedJavaClassDialog.java                |  2 +-
 .../userdefinedjavaclass/codeSnippits.xml          | 48 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 1 deletion(-)

diff --git a/plugins/transforms/janino/src/main/java/org/apache/hop/pipeline/transforms/userdefinedjavaclass/UserDefinedJavaClassDialog.java b/plugins/transforms/janino/src/main/java/org/apache/hop/pipeline/transforms/userdefinedjavaclass/UserDefinedJavaClassDialog.java
index b4866b7..3c6ee93 100644
--- a/plugins/transforms/janino/src/main/java/org/apache/hop/pipeline/transforms/userdefinedjavaclass/UserDefinedJavaClassDialog.java
+++ b/plugins/transforms/janino/src/main/java/org/apache/hop/pipeline/transforms/userdefinedjavaclass/UserDefinedJavaClassDialog.java
@@ -1019,7 +1019,7 @@ public class UserDefinedJavaClassDialog extends BaseTransformDialog implements I
     int columnNumber = widget.getColumnNumber();
     wlPosition.setText(
         BaseMessages.getString(
-            PKG, "DefinedJavaClassDialog.Position.Label2", "" + lineNumber, "" + columnNumber));
+            PKG, "UserDefinedJavaClassDialog.Position.Label", "" + lineNumber, "" + columnNumber));
   }
 
   /** Copy information from the meta-data input to the dialog fields. */
diff --git a/plugins/transforms/janino/src/main/resources/org/apache/hop/pipeline/transforms/userdefinedjavaclass/codeSnippits.xml b/plugins/transforms/janino/src/main/resources/org/apache/hop/pipeline/transforms/userdefinedjavaclass/codeSnippits.xml
index ffe9626..a8ffe02 100644
--- a/plugins/transforms/janino/src/main/resources/org/apache/hop/pipeline/transforms/userdefinedjavaclass/codeSnippits.xml
+++ b/plugins/transforms/janino/src/main/resources/org/apache/hop/pipeline/transforms/userdefinedjavaclass/codeSnippits.xml
@@ -270,6 +270,54 @@ public boolean processRow() throws HopException {
 ]]></sample>
     </codeSnippit>
     <codeSnippit>
+        <name>Implement processRow</name>
+        <category>COMMON</category>
+        <code><![CDATA[
+//
+// Perform the equivalent of processing one row. Typically this means reading a row from input
+// (getRow()) and passing a row to output (putRow)).
+//
+// @return false if no more rows can be processed or an error occurred.
+// @throws HopException
+//
+public boolean processRow() throws HopException {
+
+    return true;
+}
+]]></code>
+        <sample><![CDATA[
+//
+// Perform the equivalent of processing one row. Typically this means reading a row from input
+// (getRow()) and passing a row to output (putRow)).
+//
+// @return false if no more rows can be processed or an error occurred.
+// @throws HopException
+//
+public boolean processRow() throws HopException {
+    // If the row object is null, we are done processing.
+    if (r == null && !first) {
+        setOutputDone();
+        return false;
+    }
+
+    // If the global "first" flag is true, perform some initialization that can only happen
+    // once we have read the first row of input data
+    if (first) {
+        first = false;
+    }
+
+    // It is always safest to call createOutputRow() to ensure that your output row's Object[] is large
+    // enough to handle any new fields you are creating in this transform.
+    r = createOutputRow(r, outputRowSize);
+
+    // putRow will send the row on to the default output hop.
+    putRow(data.outputRowMeta, r);
+
+    return true;
+}
+]]></sample>
+    </codeSnippit>
+    <codeSnippit>
         <name>getRow</name>
         <category>COMMON</category>
         <code><![CDATA[Object[] r = getRow();