[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #15: AMQNET-596: Added local message expiry connection uri connection property

[GitBox <gi...@apache.org>]

Havret commented on a change in pull request #15: AMQNET-596: Added local message expiry connection uri connection property
URL: https://github.com/apache/activemq-nms-amqp/pull/15#discussion_r312696052
 
 

 ##########
 File path: src/NMS.AMQP/NmsConnectionFactory.cs
 ##########
 @@ -99,6 +99,11 @@ private IdGenerator ConnectionIdGenerator
             }
         }
 
+        /// <summary>
+        /// Enables local message expiry for all MessageConsumers under the connection. Default is true.
+        /// </summary>
+        public bool IsLocalMessageExpiry { get; set; } = true;
 
 Review comment:
   To keep things consistent with qpid implementation I would rename this property to `LocalMessageExpiry`.
   
   https://qpid.apache.org/releases/qpid-jms-0.44.0/docs/index.html
   
   We are using this property name to parse options from conneciton uri, thus following string will not not be parsed correctly: `nms.localMessageExpiry=false`. 
   
   As for now we have rather poor docs, it would make better sense to keep options adjacent to qpid as their docs will be treated as reference by our users. At least at first. 
   
   Not sure what to do with other places (`ConnectionInfo`, `ConsumerInfo`). It's rather up to you. I personally like to have things consistent from top to bottom. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services