You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/11 22:30:00 UTC
[jira] [Work logged] (GOBBLIN-1668) Add audit counts for iceberg registration
[ https://issues.apache.org/jira/browse/GOBBLIN-1668?focusedWorklogId=789760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789760 ]
ASF GitHub Bot logged work on GOBBLIN-1668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/22 22:29
Start Date: 11/Jul/22 22:29
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3527:
URL: https://github.com/apache/gobblin/pull/3527
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1668
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Pass audit count maps from streaming through a new field in GMCE, then publish those counts to a new tier after iceberg registration is done.
- Add a new field in GMCE to contain a serialized audit map string
- Populate this in MCE publisher using key `SERIALIZED_AUDIT_MAP_KEY` (will be set internally)
- After iceberg commit, call sendAuditCounts using the map from the GMCE (will be implemented internally)
- Also use a new WhitelistBlacklist for sending these audit counts, because we may want to count only for specific dbs.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Tested in parallel pipeline
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 789760)
Remaining Estimate: 0h
Time Spent: 10m
> Add audit counts for iceberg registration
> -----------------------------------------
>
> Key: GOBBLIN-1668
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1668
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)