Re: [PR] FsspecFileIO: Resolve the ADLS account per location instead of caching it in properties [iceberg-python]

["rambleraptor (via GitHub)" <gi...@apache.org>]

rambleraptor commented on code in PR #3886:
URL: https://github.com/apache/iceberg-python/pull/3886#discussion_r3983240523


##########
pyiceberg/io/fsspec.py:
##########
@@ -265,17 +265,23 @@ def _adls(properties: Properties, hostname: str | None = None) -> AbstractFileSy
     from azure.core.credentials import AccessToken
     from azure.core.credentials_async import AsyncTokenCredential
 
-    for key, sas_token in {
+    # These are resolved into locals rather than written back into `properties`. The same

Review Comment:
   This comment doesn't seem necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org