You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/04/05 14:56:14 UTC

[commons-fileupload] 01/04: Fail fast when a repository contains a null character.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git

commit 76e1e8e88d03df0795cc8f327482922e9154f02c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Apr 4 17:56:29 2023 -0400

    Fail fast when a repository contains a null character.
---
 .../org/apache/commons/fileupload2/DiskFileItemSerializeTest.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/test/java/org/apache/commons/fileupload2/DiskFileItemSerializeTest.java b/src/test/java/org/apache/commons/fileupload2/DiskFileItemSerializeTest.java
index a6565f8..d91362a 100644
--- a/src/test/java/org/apache/commons/fileupload2/DiskFileItemSerializeTest.java
+++ b/src/test/java/org/apache/commons/fileupload2/DiskFileItemSerializeTest.java
@@ -29,6 +29,7 @@ import java.io.IOException;
 import java.io.ObjectOutputStream;
 import java.io.OutputStream;
 import java.io.UncheckedIOException;
+import java.nio.file.InvalidPathException;
 
 import org.apache.commons.fileupload2.disk.DiskFileItemFactory;
 import org.apache.commons.io.FileUtils;
@@ -209,15 +210,14 @@ public class DiskFileItemSerializeTest {
     }
 
     /**
-     * Test deserialization fails when repository contains a null character.
+     * Fails when repository contains a null character.
      */
     @Test
     public void testInvalidRepositoryWithNullChar() throws IOException {
         // Create the FileItem
         final byte[] testFieldValueBytes = createContentBytes(THRESHOLD);
         final File repository = new File(FileUtils.getTempDirectory(), "\0");
-        final FileItem item = createFileItem(testFieldValueBytes, repository);
-        assertThrows(IOException.class, () -> deserialize(serialize(item)));
+        assertThrows(InvalidPathException.class, () -> createFileItem(testFieldValueBytes, repository));
     }
 
     /**