You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "paulirwin (via GitHub)" <gi...@apache.org> on 2026/07/05 20:11:00 UTC

Re: [PR] Implement IEnumerable/IEnumerator in AbstractAppendingInt64Buffer, #279 [lucenenet]

paulirwin commented on PR #1396:
URL: https://github.com/apache/lucenenet/pull/1396#issuecomment-4887442374

   I agree that there isn't much gained here, but this has been an open issue forever and it finally clears this out. Also, I think there is some good gained here: the call sites are now cleaner.
   
   (I'd like to take a second to emphasize that this issue has been open for over 14 years...)
   
   Importantly, this PR also doesn't cause any problems. I think we can merge it as-is as a lucenenet-specific change.
   
   As discussed in https://github.com/apache/lucenenet/issues/1293#issuecomment-4771893699, I do not believe we should move the goalposts and target 4.10.4. We're so close to the finish line, and our users are so desperate for a final release, that we can wrap up 4.8.1 (+ any important bug fixes only from 4.8.1-4.10.4), and then we can decide if we want to do a 4.10.4 small release (I think this would be a good idea) or pivot to a later release. But, I think we should discuss that there, not here.
   
   Regardless, there is no harm in making this change, so I think we should do it and close out this issue that has been open for over a decade and call it done. Even if this code ends up going away soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org