You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/20 08:06:16 UTC
[GitHub] [incubator-seatunnel] lhyundeadsoul opened a new pull request, #2219: [Feature][connector-tidb] add tidb connector
lhyundeadsoul opened a new pull request, #2219:
URL: https://github.com/apache/incubator-seatunnel/pull/2219
…connector and do some simplification such as removing postgre dialect etc.
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
refer to https://github.com/apache/incubator-seatunnel/issues/2173
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lhyundeadsoul commented on pull request #2219: [Feature][connector-tidb][PIW] add tidb connector
Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #2219:
URL: https://github.com/apache/incubator-seatunnel/pull/2219#issuecomment-1191278053
> If it is only based on the jdbc connector, it is better to support TiDB directly in the JDBC connector. You now have a lot of the same code for the tidb connector and the JDBC connector,It's not good for maintenance.
I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lhyundeadsoul closed pull request #2219: [Feature][connector-tidb][PIW] add tidb connector
Posted by GitBox <gi...@apache.org>.
lhyundeadsoul closed pull request #2219: [Feature][connector-tidb][PIW] add tidb connector
URL: https://github.com/apache/incubator-seatunnel/pull/2219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lhyundeadsoul commented on pull request #2219: [Feature][connector-tidb][PIW] add tidb connector
Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #2219:
URL: https://github.com/apache/incubator-seatunnel/pull/2219#issuecomment-1191016449
>
We have discussed this in https://github.com/apache/incubator-seatunnel/issues/2173 ,but we have no further idea. TiDB obeys MySQL protocol, indeed it can handle by JDBC connector. So I did some simplification, such as removing MYSQL Dialect etc. If there are some special optimization for TiDB , we can add them based on this module.
Is there any good idea ,please let me know. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #2219: [Feature][connector-tidb][PIW] add tidb connector
Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2219:
URL: https://github.com/apache/incubator-seatunnel/pull/2219#issuecomment-1191013905
@lhyundeadsoul thanks for your contribution
Is there any difference with the JDBC connector currently, or is there any optimization point。Currently looks the same as the JDBC connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #2219: [Feature][connector-tidb][PIW] add tidb connector
Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2219:
URL: https://github.com/apache/incubator-seatunnel/pull/2219#issuecomment-1191099404
If it is only based on the jdbc connector, it is better to support TiDB directly in the JDBC connector. You now have a lot of the same code for the tidb connector and the JDBC connector,It's not good for maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org