[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1838: chore: use data value directly in tests

[GitBox <gi...@apache.org>]

guoqqqi commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627335494



##########
File path: web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##########
@@ -17,38 +17,52 @@
 /* eslint-disable no-undef */
 
 context('Create and delete consumer with proxy-mirror plugin form', () => {
-  beforeEach(() => {
-    cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
-  });
-
   const selector = {
+    empty:'.ant-empty-normal',
+    username: '#username',
+    description: '#desc',
+    pluginCard: '.ant-card',
+    drawer: '.ant-drawer-content',
+    dropdown: '.rc-virtual-list',
+    disabledSwitcher: '#disable',
+    codeMirror: '.CodeMirror',
+    notification: '.ant-notification-notice-message',
+    notificationCloseIcon: '.ant-notification-close-icon',
     host: "#host",
     alert: "[role=alert]"
   }

Review comment:
       ```suggestion
       notification: '.ant-notification-notice-message',
       notificationCloseIcon: '.ant-notification-close-icon',
        host: '#host',
        alert: '[role=alert]'
      }
   ```
   It is best to use both single and double quotation marks
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org