[GitHub] [cassandra] maedhroz commented on a change in pull request #729: CASSANDRA-15954: Include taskId in the compactionInfo toString

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #729:
URL: https://github.com/apache/cassandra/pull/729#discussion_r483770390



##########
File path: src/java/org/apache/cassandra/db/compaction/CompactionInfo.java
##########
@@ -132,6 +132,13 @@ public String toString()
         StringBuilder buff = new StringBuilder();
         buff.append(getTaskType());
 
+        if (getTaskId() != null)
+        {
+            buff.append('(')
+                .append(getTaskId())
+                .append(')');
+        }

Review comment:
       @dcapwell @yifan-c I don't think there's any codepath where the task ID can be null. We might as well avoid the check and make this a one-liner. (Even if it is null, it won't make anything explode...)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org