You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2017/01/10 06:23:05 UTC
[GitHub] zeppelin pull request #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1879
[HOTFIX : ZEPPELIN-1932] paragraph blur error
### What is this PR for?
When one or more hidden editors are present, clicking on the editor will cause a blur error.
This means that when a paragraph is hidden through ng-if,
Caused by calling the blur method in the absence of an editor object.
### What type of PR is it?
Hot Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1932
### How should this be tested?
1. create paragraph and open debug console.
2. enable hide paragraph.
3. page refresh
4. click to anywhere paragraph.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix/paragraphOnfocusEvent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1879
----
commit c2f99adbab3e7a8b51543d2e04a5c09bc28955d5
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-10T06:18:14Z
bug fixed when paragraph for not rendering onReceived broadcast event
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1879
[HOTFIX : ZEPPELIN-1932] paragraph blur error
### What is this PR for?
When one or more hidden editors are present, clicking on the editor will cause a blur error.
This means that when a paragraph is hidden through ng-if,
Caused by calling the blur method in the absence of an editor object.
### What type of PR is it?
Hot Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1932
### How should this be tested?
1. create paragraph and open debug console.
2. enable hide paragraph.
3. page refresh
4. click to anywhere paragraph.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix/paragraphOnfocusEvent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1879
----
commit c2f99adbab3e7a8b51543d2e04a5c09bc28955d5
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-10T06:18:14Z
bug fixed when paragraph for not rendering onReceived broadcast event
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1879
@cloverhearts Can you also look into https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L764 this line?
I see another error related to editor.
How to reproduce
1. go to `Basic Features (Spark)` tutorial notebook
2. run first markdown paragraph
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1879
[HOTFIX : ZEPPELIN-1932] paragraph blur error
### What is this PR for?
When one or more hidden editors are present, clicking on the editor will cause a blur error.
This means that when a paragraph is hidden through ng-if,
Caused by calling the blur method in the absence of an editor object.
### What type of PR is it?
Hot Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1932
### How should this be tested?
1. create paragraph and open debug console.
2. enable hide paragraph.
3. page refresh
4. click to anywhere paragraph.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix/paragraphOnfocusEvent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1879
----
commit 5ecfabbe45131826b597ca430ff833f0094cf482
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-11T05:30:35Z
check editor object is undeifned.
commit 8f4d0bf9cbb02b264d095010ed0734e02869f861
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-11T10:23:38Z
fixed readonly event error
commit 7071638f93085482b3c91837c7c369051d2d9bac
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-13T02:53:10Z
fix show title and paragraph context issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1879
Tested, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1879
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1879
@cloverhearts Thank you :+1:
Let me test it out and I'll comment this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1879
Tested and it works well :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1879
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1879
@soralee
Sure :)
rebase is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1879
Merge if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1879
@cloverhearts I'd like to test this. could you resolve some conflict file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1879
@minahlee Okay, I will take look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1879
@cloverhearts update looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---