You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/05/17 06:34:00 UTC

[GitHub] [dubbo-go-pixiu] mark4z opened a new pull request #169: rate limit filter

mark4z opened a new pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #10
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90836a4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...90836a4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on a change in pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
mark4z commented on a change in pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#discussion_r657569826



##########
File path: pkg/filter/ratelimit/matcher/exact.go
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package matcher
+
+import (
+	"github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config/ratelimit"
+)
+
+import (
+	"sync"
+)
+
+type Exact struct {
+	apiNames map[string]string
+
+	mu sync.RWMutex

Review comment:
       mu *sync.RWMutex, this way?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] xiaoliu10 merged pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
xiaoliu10 merged pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (153e99c) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.16%`.
   > The diff coverage is `36.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.43%   -0.17%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1746      +54     
   ===========================================
   + Hits           687      706      +19     
   - Misses         903      935      +32     
   - Partials       102      105       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `71.42% <71.42%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...153e99c](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be02472) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/b6f255b6246977ed718a020205029dc2b9d78e65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6f255b) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b6f255b...be02472](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-860135380


   pls fix the go.mod confliction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90836a4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...90836a4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49015e4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...49015e4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] zhangshen023 commented on a change in pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
zhangshen023 commented on a change in pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#discussion_r656728346



##########
File path: pkg/filter/ratelimit/logger_warpper.go
##########
@@ -0,0 +1,62 @@
+/*

Review comment:
       what does this code make sense?

##########
File path: pkg/filter/ratelimit/matcher/exact.go
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package matcher
+
+import (
+	"github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config/ratelimit"
+)
+
+import (
+	"sync"
+)
+
+type Exact struct {
+	apiNames map[string]string
+
+	mu sync.RWMutex

Review comment:
       FYI,I think pointer is better

##########
File path: pkg/filter/plugins/plugins.go
##########
@@ -165,7 +189,7 @@ func getAPIFilterFuncsWithPluginsGroup(plu *config.PluginsInUse) []context.Filte
 
 	// found with group name
 	for _, groupName := range plu.GroupNames {
-		pwfMap, found := groupWithPluginsMap[groupName]
+		pwfMap, found := groupCache[groupName]
 		if found {

Review comment:
       `	if !found {
   		continue
   	}
   	for _, pwf := range pwfMap {
   		tmpMap[pwf.Name] = pwf.fn
   	}
   `




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33e3246) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/4bae7298a284c91b700529291a5bf6bab56dbcbc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bae729) will **increase** coverage by `0.15%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   + Coverage    43.14%   43.29%   +0.15%     
   ===========================================
     Files           33       37       +4     
     Lines         1757     1834      +77     
   ===========================================
   + Hits           758      794      +36     
   - Misses         890      928      +38     
   - Partials       109      112       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.58% <0.00%> (-0.21%)` | :arrow_down: |
   | [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `64.91% <0.00%> (-0.09%)` | :arrow_down: |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/plugins/plugins.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9wbHVnaW5zL3BsdWdpbnMuZ28=) | `31.25% <26.08%> (-2.09%)` | :arrow_down: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `64.70% <64.70%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `100.00% <100.00%> (ø)` | |
   | ... and [5 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4bae729...33e3246](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93363b7) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/b6f255b6246977ed718a020205029dc2b9d78e65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6f255b) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b6f255b...93363b7](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c865a5d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/985a285d29025c5e55c0407fc84f32a3b16d2e91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (985a285) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [985a285...c865a5d](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on a change in pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
mark4z commented on a change in pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#discussion_r648948602



##########
File path: pkg/filter/ratelimit/init.go
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package ratelimit
+
+import (
+	sentinel "github.com/alibaba/sentinel-golang/api"
+	sc "github.com/alibaba/sentinel-golang/core/config"
+	"github.com/alibaba/sentinel-golang/core/flow"
+	"github.com/alibaba/sentinel-golang/logging"
+	"github.com/pkg/errors"
+)
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/filter/ratelimit/config"
+	"github.com/apache/dubbo-go-pixiu/pkg/filter/ratelimit/matcher"
+	"github.com/apache/dubbo-go-pixiu/pkg/logger"
+)
+
+func GetConfig() *config.Config {
+	c, _ := GetMockedRateLimitConfig()

Review comment:
       yep, that func does not yet exist. i'll do it later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c865a5d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/985a285d29025c5e55c0407fc84f32a3b16d2e91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (985a285) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [985a285...c865a5d](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (153e99c) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.16%`.
   > The diff coverage is `36.36%`.
   
   > :exclamation: Current head 153e99c differs from pull request most recent head 02cb291. Consider uploading reports for the commit 02cb291 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.43%   -0.17%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1746      +54     
   ===========================================
   + Hits           687      706      +19     
   - Misses         903      935      +32     
   - Partials       102      105       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `71.42% <71.42%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...02cb291](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c7985d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/4bae7298a284c91b700529291a5bf6bab56dbcbc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bae729) will **increase** coverage by `0.15%`.
   > The diff coverage is `44.44%`.
   
   > :exclamation: Current head 5c7985d differs from pull request most recent head 33e3246. Consider uploading reports for the commit 33e3246 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   + Coverage    43.14%   43.29%   +0.15%     
   ===========================================
     Files           33       37       +4     
     Lines         1757     1834      +77     
   ===========================================
   + Hits           758      794      +36     
   - Misses         890      928      +38     
   - Partials       109      112       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.58% <0.00%> (-0.21%)` | :arrow_down: |
   | [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `64.91% <0.00%> (-0.09%)` | :arrow_down: |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/plugins/plugins.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9wbHVnaW5zL3BsdWdpbnMuZ28=) | `31.25% <26.08%> (-2.09%)` | :arrow_down: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `64.70% <64.70%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `100.00% <100.00%> (ø)` | |
   | ... and [5 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4bae729...33e3246](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c73a7d0) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...c73a7d0](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (972b671) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   > :exclamation: Current head 972b671 differs from pull request most recent head 153e99c. Consider uploading reports for the commit 153e99c to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...153e99c](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15a66ed) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **decrease** coverage by `0.20%`.
   > The diff coverage is `35.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.40%   -0.21%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1745      +53     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      935      +32     
   - Partials       102      105       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `70.00% <70.00%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...15a66ed](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] williamfeng323 commented on a change in pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
williamfeng323 commented on a change in pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#discussion_r648946095



##########
File path: pkg/filter/ratelimit/init.go
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package ratelimit
+
+import (
+	sentinel "github.com/alibaba/sentinel-golang/api"
+	sc "github.com/alibaba/sentinel-golang/core/config"
+	"github.com/alibaba/sentinel-golang/core/flow"
+	"github.com/alibaba/sentinel-golang/logging"
+	"github.com/pkg/errors"
+)
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/filter/ratelimit/config"
+	"github.com/apache/dubbo-go-pixiu/pkg/filter/ratelimit/matcher"
+	"github.com/apache/dubbo-go-pixiu/pkg/logger"
+)
+
+func GetConfig() *config.Config {
+	c, _ := GetMockedRateLimitConfig()

Review comment:
       i think you might call the wrong function.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #169: rate limit filter

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#169](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93363b7) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/b6f255b6246977ed718a020205029dc2b9d78e65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6f255b) will **decrease** coverage by `0.24%`.
   > The diff coverage is `33.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #169      +/-   ##
   ===========================================
   - Coverage    40.60%   40.35%   -0.25%     
   ===========================================
     Files           35       39       +4     
     Lines         1692     1747      +55     
   ===========================================
   + Hits           687      705      +18     
   - Misses         903      936      +33     
   - Partials       102      106       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
   | [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <11.11%> (ø)` | |
   | [pkg/filter/ratelimit/mock.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbW9jay5nbw==) | `50.00% <50.00%> (ø)` | |
   | [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.00% <50.00%> (+0.61%)` | :arrow_up: |
   | [pkg/filter/ratelimit/init.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvaW5pdC5nbw==) | `63.63% <63.63%> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b6f255b...93363b7](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org