You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/08/11 08:01:06 UTC
[orc] branch branch-1.6 updated: ORC-936: Add `-DANALYZE_JAVA=ON`
to `branch-1.6` GitHub Action (#849)
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.6
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.6 by this push:
new d21a8f8 ORC-936: Add `-DANALYZE_JAVA=ON` to `branch-1.6` GitHub Action (#849)
d21a8f8 is described below
commit d21a8f88646ee40eeebbaf9394dbb56516c25dc5
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Wed Aug 11 01:00:37 2021 -0700
ORC-936: Add `-DANALYZE_JAVA=ON` to `branch-1.6` GitHub Action (#849)
### What changes were proposed in this pull request?
This PR aims to enable `ANALYZE_JAVA` in `branch-1.6` to be consistent with the other branches.
### Why are the changes needed?
For example, without `ANALYZE_JAVA`, benchmark module is not built at all.
### How was this patch tested?
Pass the GitHub Action.
---
.github/workflows/build_and_test.yml | 2 +-
java/core/src/findbugs/exclude.xml | 4 ++++
java/tools/src/findbugs/exclude.xml | 5 +++++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index 77ac1c2..7a69bf0 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -41,7 +41,7 @@ jobs:
mkdir -p ~/.m2
mkdir build
cd build
- cmake ..
+ cmake -DANALYZE_JAVA=ON ..
make package test-out
cd ../java
mvn apache-rat:check
diff --git a/java/core/src/findbugs/exclude.xml b/java/core/src/findbugs/exclude.xml
index 73ac38b..feb275d 100644
--- a/java/core/src/findbugs/exclude.xml
+++ b/java/core/src/findbugs/exclude.xml
@@ -66,6 +66,10 @@
<Class name="org.apache.orc.TestStringDictionary"/>
</Match>
<Match>
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
+ <Class name="~org\.apache\.orc.*\.Test.*"/>
+ </Match>
+ <Match>
<Bug pattern="EQ_UNUSUAL"/>
<Class name="org.apache.orc.TypeDescription"/>
<Method name="equals" />
diff --git a/java/tools/src/findbugs/exclude.xml b/java/tools/src/findbugs/exclude.xml
index be94306..c04cd9e 100644
--- a/java/tools/src/findbugs/exclude.xml
+++ b/java/tools/src/findbugs/exclude.xml
@@ -23,4 +23,9 @@
<Class name="org.apache.orc.tools.PrintVersion"/>
<Method name="main"/>
</Match>
+ <Match>
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
+ <Class name="org.apache.orc.impl.TestRLEv2"/>
+ <Method name="testBaseValueLimit"/>
+ </Match>
</FindBugsFilter>