[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4423: ARTEMIS-4210 refactor connection audit logging

["jbertram (via GitHub)" <gi...@apache.org>]

jbertram commented on code in PR #4423:
URL: https://github.com/apache/activemq-artemis/pull/4423#discussion_r1153769042


##########
artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AuditLogger.java:
##########
@@ -2646,14 +2641,14 @@ static void isAutoDelete(Object source) {
    void isAutoDelete(String user, Object source);
 
    static void createdConnection(String protocol, Object connectionID, String remoteAddress) {
-      CONNECTION_LOGGER.createdConnection(protocol, connectionID.toString(), String.format("unknown%s", formatRemoteAddress(remoteAddress)));
+      RESOURCE_LOGGER.createdConnection(protocol, connectionID == null ? null : connectionID.toString(), String.format("unknown%s", formatRemoteAddress(remoteAddress)));

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org